Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: chrome/renderer/prerender/prerender_helper.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/prerender/prerender_helper.h" 5 #include "chrome/renderer/prerender/prerender_helper.h"
6 6
7 #include "base/metrics/field_trial.h" 7 #include "base/metrics/field_trial.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "chrome/common/prerender_messages.h" 9 #include "chrome/common/prerender_messages.h"
10 #include "content/public/renderer/document_state.h" 10 #include "content/public/renderer/document_state.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 66
67 content::RenderFrame* frame = render_frame(); 67 content::RenderFrame* frame = render_frame();
68 // |this| must be deleted so PrerenderHelper::IsPrerendering returns false 68 // |this| must be deleted so PrerenderHelper::IsPrerendering returns false
69 // when the visibility state is updated, so the visibility state string will 69 // when the visibility state is updated, so the visibility state string will
70 // not be "prerendered". 70 // not be "prerendered".
71 delete this; 71 delete this;
72 72
73 UpdateVisibilityState(frame); 73 UpdateVisibilityState(frame);
74 } 74 }
75 75
76 void PrerenderHelper::OnDestruct() {
77 delete this;
78 }
79
76 } // namespace prerender 80 } // namespace prerender
OLDNEW
« no previous file with comments | « chrome/renderer/prerender/prerender_helper.h ('k') | chrome/renderer/prerender/prerenderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698