Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/renderer/plugins/plugin_preroller.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/renderer/pepper/pepper_helper.cc ('k') | chrome/renderer/plugins/plugin_preroller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_PLUGINS_PLUGIN_PREROLLER_H_ 5 #ifndef CHROME_RENDERER_PLUGINS_PLUGIN_PREROLLER_H_
6 #define CHROME_RENDERER_PLUGINS_PLUGIN_PREROLLER_H_ 6 #define CHROME_RENDERER_PLUGINS_PLUGIN_PREROLLER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "content/public/common/webplugininfo.h" 9 #include "content/public/common/webplugininfo.h"
10 #include "content/public/renderer/plugin_instance_throttler.h" 10 #include "content/public/renderer/plugin_instance_throttler.h"
(...skipping 26 matching lines...) Expand all
37 content::PluginInstanceThrottler* throttler); 37 content::PluginInstanceThrottler* throttler);
38 38
39 ~PluginPreroller() override; 39 ~PluginPreroller() override;
40 40
41 private: 41 private:
42 // content::PluginInstanceThrottler::Observer methods: 42 // content::PluginInstanceThrottler::Observer methods:
43 void OnKeyframeExtracted(const SkBitmap* bitmap) override; 43 void OnKeyframeExtracted(const SkBitmap* bitmap) override;
44 void OnThrottleStateChange() override; 44 void OnThrottleStateChange() override;
45 void OnThrottlerDestroyed() override; 45 void OnThrottlerDestroyed() override;
46 46
47 // content::RenderFrameObserver implementation.
48 void OnDestruct() override;
49
47 blink::WebLocalFrame* frame_; 50 blink::WebLocalFrame* frame_;
48 blink::WebPluginParams params_; 51 blink::WebPluginParams params_;
49 content::WebPluginInfo info_; 52 content::WebPluginInfo info_;
50 std::string identifier_; 53 std::string identifier_;
51 base::string16 name_; 54 base::string16 name_;
52 base::string16 message_; 55 base::string16 message_;
53 56
54 content::PluginInstanceThrottler* throttler_; 57 content::PluginInstanceThrottler* throttler_;
55 58
56 GURL keyframe_data_url_; 59 GURL keyframe_data_url_;
57 60
58 DISALLOW_COPY_AND_ASSIGN(PluginPreroller); 61 DISALLOW_COPY_AND_ASSIGN(PluginPreroller);
59 }; 62 };
60 63
61 #endif // CHROME_RENDERER_PLUGINS_PLUGIN_PREROLLER_H_ 64 #endif // CHROME_RENDERER_PLUGINS_PLUGIN_PREROLLER_H_
OLDNEW
« no previous file with comments | « chrome/renderer/pepper/pepper_helper.cc ('k') | chrome/renderer/plugins/plugin_preroller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698