chrome/renderer/plugins/plugin_preroller.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/plugins/plugin_preroller.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/renderer/plugins/plugin_preroller.h"	5 #include "chrome/renderer/plugins/plugin_preroller.h"

6	6

7 #include "base/base64.h"	7 #include "base/base64.h"

8 #include "chrome/grit/renderer_resources.h"	8 #include "chrome/grit/renderer_resources.h"

9 #include "chrome/renderer/plugins/chrome_plugin_placeholder.h"	9 #include "chrome/renderer/plugins/chrome_plugin_placeholder.h"

10 #include "chrome/renderer/plugins/power_saver_info.h"	10 #include "chrome/renderer/plugins/power_saver_info.h"

(...skipping 70 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
81 container->invalidate();	81 container->invalidate();

82 container->reportGeometry();	82 container->reportGeometry();

83	83

84 delete this;	84 delete this;

85 }	85 }

86	86

87 void PluginPreroller::OnThrottlerDestroyed() {	87 void PluginPreroller::OnThrottlerDestroyed() {

88 throttler_ = nullptr;	88 throttler_ = nullptr;

89 delete this;	89 delete this;

90 }	90 }

	91

	92 void PluginPreroller::OnDestruct() {

	93 delete this;

	94 }

OLD	NEW

« no previous file with comments | « chrome/renderer/plugins/plugin_preroller.h ('k') | chrome/renderer/prerender/prerender_helper.h » ('j') | no next file with comments »