chrome/renderer/page_load_histograms.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/page_load_histograms.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/renderer/page_load_histograms.h"	5 #include "chrome/renderer/page_load_histograms.h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #include <memory>	9 #include <memory>

10 #include <string>	10 #include <string>

(...skipping 949 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
960	960

961 DCHECK(document_state);	961 DCHECK(document_state);

962 DCHECK(ds);	962 DCHECK(ds);

963 GURL url(ds->request().url());	963 GURL url(ds->request().url());

964 Time start = document_state->start_load_time();	964 Time start = document_state->start_load_time();

965 Time finish = document_state->finish_load_time();	965 Time finish = document_state->finish_load_time();

966 // TODO(mbelshe): should we log more stats?	966 // TODO(mbelshe): should we log more stats?

967 VLOG(1) << "PLT: " << (finish - start).InMilliseconds() << "ms "	967 VLOG(1) << "PLT: " << (finish - start).InMilliseconds() << "ms "

968 << url.spec();	968 << url.spec();

969 }	969 }

	970

	971 void PageLoadHistograms::OnDestruct() {

	972 delete this;

	973 }

OLD	NEW

« no previous file with comments | « chrome/renderer/page_load_histograms.h ('k') | chrome/renderer/pepper/pepper_helper.h » ('j') | content/public/renderer/render_frame_observer.h » ('J')