Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2034133002:
💢 target_cpu -> current_cpu in build/config/compiler/BUILD.gn (Closed)
|
Created:
4 years, 6 months ago by agrieve Modified:
4 years, 6 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiontarget_cpu -> current_cpu in build/config/compiler/BUILD.gn
BUG=616819
Committed: https://crrev.com/24550c794619b7574fcfc7c266bd6441b833e532
Cr-Commit-Position: refs/heads/master@{#398567}
Patch Set 1 #
Messages
Total messages: 16 (7 generated)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034133002/1
Description was changed from ========== target_cpu -> current_cpu in build/config/compiler/BUILD.gn BUG=616819 ========== to ========== target_cpu -> current_cpu in build/config/compiler/BUILD.gn BUG=616819 ==========
agrieve@chromium.org changed reviewers: + dpranke@chromium.org
On 2016/06/03 15:48:41, commit-bot: I haz the power wrote: > Dry run: CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/2034133002/1 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/2034133002/1
On 2016/06/03 16:11:25, agrieve wrote: > On 2016/06/03 15:48:41, commit-bot: I haz the power wrote: > > Dry run: CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/patch-status/2034133002/1 > > View timeline at > > https://chromium-cq-status.appspot.com/patch-timeline/2034133002/1 Did you try your patches by setting arm as default, and arm64 as secondary toolchain? I recalled I got issue that current_cpu is aarch64 in this case.
On 2016/06/03 17:00:46, michaelbai wrote: > On 2016/06/03 16:11:25, agrieve wrote: > > On 2016/06/03 15:48:41, commit-bot: I haz the power wrote: > > > Dry run: CQ is trying da patch. Follow status at > > > https://chromium-cq-status.appspot.com/patch-status/2034133002/1 > > > View timeline at > > > https://chromium-cq-status.appspot.com/patch-timeline/2034133002/1 > > Did you try your patches by setting arm as default, and arm64 as secondary > toolchain? I recalled I got issue that current_cpu is aarch64 in this case. I tried only with arm64 as default, but likely https://codereview.chromium.org/2036263002/ is what you would have noticed.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034133002/1
Message was sent while issue was closed.
Description was changed from ========== target_cpu -> current_cpu in build/config/compiler/BUILD.gn BUG=616819 ========== to ========== target_cpu -> current_cpu in build/config/compiler/BUILD.gn BUG=616819 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== target_cpu -> current_cpu in build/config/compiler/BUILD.gn BUG=616819 ========== to ========== target_cpu -> current_cpu in build/config/compiler/BUILD.gn BUG=616819 Committed: https://crrev.com/24550c794619b7574fcfc7c266bd6441b833e532 Cr-Commit-Position: refs/heads/master@{#398567} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/24550c794619b7574fcfc7c266bd6441b833e532 Cr-Commit-Position: refs/heads/master@{#398567} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
