Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 203413008: Revert of Web Animations API: Load resources referenced in element.animate() (Closed)

Created:
6 years, 9 months ago by alancutter (OOO until 2018)
Modified:
6 years, 9 months ago
Reviewers:
dstockwell, esprehn
CC:
blink-reviews, shans, eae+blinkwatch, apavlov+blink_chromium.org, Steve Block, rwlbuis, dino_apple.com, bemjb+rendering_chromium.org, dsinclair, Timothy Loh, dstockwell, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink, Eric Willigers, rjwright, zoltan1, darktears, leviw+renderwatch, Mike Lawther (Google), ed+blinkwatch_opera.com
Visibility:
Public.

Description

Revert of Web Animations API: Load resources referenced in element.animate() (https://codereview.chromium.org/196573030/) Reason for revert: Causing assertion failure in ChromeOS browser_tests. https://code.google.com/p/chromium/issues/detail?id=353962 Original issue's description: > Web Animations API: Load resources referenced in element.animate() > > This patch fixes a bug where resources in element.animate() calls were > not being fetched. This resulted in StylePendingImages leaking out of > the style resolving stage and into rendering which causes a crash. > > This patch fixes the bug by ensuring StylePendingImages introduced in > applyAnimatedProperties() will be resolved as non-pending StyleImages > through an additional call to loadPendingResources(). > This patch also modifies AnimatableImage to be a wrapper of CSSValues > instead of StyleImages in order to follow the same resource caching > logic as typical CSS image values. > This patch also updates EffectInput::convert() to pass the document's > StyleSheetContents to MutableStylePropertySet::setProperty() so that > relative URLs are correctly resolved to absolute URLs. > > BUG=353385 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169424 TBR=dstockwell@chromium.org,esprehn@chromium.org NOTREECHECKS=true NOTRY=true BUG=353385 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169539

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -88 lines) Patch
D LayoutTests/web-animations-api/resource-loading.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/web-animations-api/resource-loading-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/AnimatableImage.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/animation/AnimatableImage.cpp View 2 chunks +33 lines, -9 lines 0 comments Download
M Source/core/animation/AnimatableValueTestHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/EffectInput.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/resolver/ElementStyleResources.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/resolver/ElementStyleResources.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 6 chunks +9 lines, -14 lines 0 comments Download
M Source/core/css/resolver/StyleResourceLoader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResourceLoader.cpp View 4 chunks +2 lines, -6 lines 0 comments Download
M Source/core/rendering/style/StyleFetchedImage.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alancutter (OOO until 2018)
Created Revert of Web Animations API: Load resources referenced in element.animate()
6 years, 9 months ago (2014-03-19 10:59:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/203413008/1
6 years, 9 months ago (2014-03-19 10:59:29 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 11:00:09 UTC) #3
Message was sent while issue was closed.
Change committed as 169539

Powered by Google App Engine
This is Rietveld 408576698