Issue 203413006: [CSS Shapes] shape-outside: ellipse(50% 50% at) causes crash

Issue 203413006: [CSS Shapes] shape-outside: ellipse(50% 50% at) causes crash (Closed)

Created:
6 years, 9 months ago by rwlbuis

Modified:
6 years, 9 months ago

Reviewers:
leviw_travelin_and_unemployed, Hans Muller

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

[CSS Shapes] shape-outside: ellipse(50% 50% at) causes crash The BasicShape ellipse and circle functions now report a syntax error if the "at" keyword is not followed by a position. The existing parsing tests have been updated to include this case. Ported over from http://trac.webkit.org/changeset/165835 BUG=353774 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169583

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -7 lines)			Patch
M	LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-test-utils.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	4 chunks	+5 lines, -7 lines	0 comments	Download

Total messages: 7 (0 generated)

rwlbuis

Adding Hans to verify I did not mess up porting the patch over :)

6 years, 9 months ago (2014-03-19 15:24:25 UTC) #2

Hans Muller

On 2014/03/19 15:24:25, rwlbuis wrote: > Adding Hans to verify I did not mess up ...

6 years, 9 months ago (2014-03-19 15:30:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/203413006/1

6 years, 9 months ago (2014-03-19 20:18:15 UTC) #6

Message was sent while issue was closed.

Change committed as 169583