telemetry, mac: Add more simple scrolling power tests.

telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/3885ecfd5ff0a486f97839089eb739a39f66960b
Cr-Commit-Position: refs/heads/master@{#398143}

[erikchen, 2016-06-03 15:06:35]

Description was changed from

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
==========

to

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[erikchen, 2016-06-03 15:07:16]

erikchen@chromium.org changed reviewers:
+ nednguyen@google.com

[erikchen, 2016-06-03 15:07:17]

nednguyen: Please review.

[erikchen, 2016-06-03 15:07:21]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 15:07:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034123002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034123002/1

[nednguyen, 2016-06-03 15:40:35]

On 2016/06/03 15:07:35, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/2034123002/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/2034123002/1

lgtm but just to consider, you can have a special subclass of shared_page_state
that allow switching the browser options. That way you have 1 benchmark with 3
pages, each has a different browser options. The benefit is less benchmarks to
manage & we have a combined graphs of power on the dashboard by default.

[commit-bot: I haz the power, 2016-06-03 17:08:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 17:08:51]

Dry run: Try jobs failed on following builders:
  android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
  winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)

[erikchen, 2016-06-03 17:13:37]

Description was changed from

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
==========

[erikchen, 2016-06-06 18:01:36]

Description was changed from

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
==========

to

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[erikchen, 2016-06-06 18:02:16]

nednguyen: PTAL

[nednguyen, 2016-06-06 18:05:36]

lgtm

[erikchen, 2016-06-06 18:05:50]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-06-06 18:06:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034123002/20001

[nednguyen, 2016-06-06 18:07:23]

https://codereview.chromium.org/2034123002/diff/20001/tools/perf/page_sets/ma...
File tools/perf/page_sets/mac_gpu_sites.py (right):

https://codereview.chromium.org/2034123002/diff/20001/tools/perf/page_sets/ma...
tools/perf/page_sets/mac_gpu_sites.py:22: ['--no-gpu'])
Actually why is this flag the same as _NoGpuSharedPageState?

[nednguyen, 2016-06-06 18:07:56]

The CQ bit was unchecked by nednguyen@google.com

[erikchen, 2016-06-06 18:10:20]

https://codereview.chromium.org/2034123002/diff/20001/tools/perf/page_sets/ma...
File tools/perf/page_sets/mac_gpu_sites.py (right):

https://codereview.chromium.org/2034123002/diff/20001/tools/perf/page_sets/ma...
tools/perf/page_sets/mac_gpu_sites.py:22: ['--no-gpu'])
On 2016/06/06 18:07:23, nednguyen wrote:
> Actually why is this flag the same as _NoGpuSharedPageState?

copy paste error.

[erikchen, 2016-06-06 18:10:25]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-06-06 18:10:25]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2034123002/#ps40001
(title: "Copy paste error.")

[commit-bot: I haz the power, 2016-06-06 18:11:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034123002/40001

[commit-bot: I haz the power, 2016-06-06 20:13:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 20:13:05]

Try jobs failed on following builders:
  winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)

[nednguyen, 2016-06-06 20:45:12]

Description was changed from

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq
==========

[nednguyen, 2016-06-06 20:45:17]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-06-06 20:45:35]

On 2016/06/06 20:13:05, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)

Removed
"tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;"
because this is a mac only benchmark

[commit-bot: I haz the power, 2016-06-06 20:45:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034123002/40001

[commit-bot: I haz the power, 2016-06-06 22:29:10]

Description was changed from

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq
==========

[commit-bot: I haz the power, 2016-06-06 22:29:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-06 22:31:27]

Description was changed from

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
telemetry, mac: Add more simple scrolling power tests.

These tests measure the no-gpu and disable-mac-overlays cases.

BUG=616811
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/3885ecfd5ff0a486f97839089eb739a39f66960b
Cr-Commit-Position: refs/heads/master@{#398143}
==========

[commit-bot: I haz the power, 2016-06-06 22:31:28]

Patchset 3 (id:??) landed as
https://crrev.com/3885ecfd5ff0a486f97839089eb739a39f66960b
Cr-Commit-Position: refs/heads/master@{#398143}