Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2034093003: Added flags for previous code change (Closed)

Created:
4 years, 6 months ago by Jane
Modified:
4 years, 6 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Previous code change 2018643002 (for user menu redesign) modified code on the spot and did not put the changes behind any flag. This CL is to: 1. add flags for the previous code change; 2. add back some of the deleted resources as they will still be used when the flag is not turned on. BUG=615893 Committed: https://crrev.com/5824d7906802051e8c2193b05b83cb44494379ae Cr-Commit-Position: refs/heads/master@{#398184}

Patch Set 1 #

Patch Set 2 : Added comments #

Patch Set 3 : Fixed mac unit test #

Patch Set 4 : More unittest fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -15 lines) Patch
M chrome/app/generated_resources.grd View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
A chrome/app/theme/default_100_percent/common/incognito.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/incognito.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 2 chunks +26 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 1 2 3 4 chunks +65 lines, -13 lines 1 comment Download
M chrome/browser/ui/views/profiles/profile_chooser_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 4 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
Jane
4 years, 6 months ago (2016-06-03 21:13:33 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/2034093003/diff/60001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm (right): https://codereview.chromium.org/2034093003/diff/60001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm#newcode208 chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm:208: This won't test both cases, only the default ...
4 years, 6 months ago (2016-06-06 13:37:12 UTC) #5
Jane
On 2016/06/06 13:37:12, Roger Tawa wrote: > lgtm > > https://codereview.chromium.org/2034093003/diff/60001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm > File chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm > ...
4 years, 6 months ago (2016-06-06 13:42:17 UTC) #6
Jane
4 years, 6 months ago (2016-06-06 17:00:19 UTC) #9
Alexei Svitkine (slow)
lgtm
4 years, 6 months ago (2016-06-06 20:05:09 UTC) #10
sky
LGTM
4 years, 6 months ago (2016-06-06 22:24:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034093003/60001
4 years, 6 months ago (2016-06-06 22:38:01 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-07 01:09:34 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 01:11:05 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5824d7906802051e8c2193b05b83cb44494379ae
Cr-Commit-Position: refs/heads/master@{#398184}

Powered by Google App Engine
This is Rietveld 408576698