Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2034083003: mac/gn: Make sure components_unittests contain the same tests in gyp and gn builds. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac/gn: Make sure components_unittests contain the same tests in gyp and gn builds. Also switch bits of components_unittests's gn file from the "include everything, conditionally exclude some bits again" to the "include only what you need" pattern that's preferred in gn files. BUG=431177 Committed: https://crrev.com/63c14e06e08bca1d9ca347b6c00d2e444ab212ca Cr-Commit-Position: refs/heads/master@{#398022}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -23 lines) Patch
M components/components_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M components/policy/core/common/BUILD.gn View 6 chunks +12 lines, -23 lines 1 comment Download

Messages

Total messages: 17 (8 generated)
Nico
https://codereview.chromium.org/2034083003/diff/1/components/policy/core/common/BUILD.gn File components/policy/core/common/BUILD.gn (right): https://codereview.chromium.org/2034083003/diff/1/components/policy/core/common/BUILD.gn#newcode277 components/policy/core/common/BUILD.gn:277: sources += [ "mac_util_unittest.cc" ] (that's the new file ...
4 years, 6 months ago (2016-06-03 19:19:49 UTC) #3
Robert Sesek
LGTM
4 years, 6 months ago (2016-06-03 19:41:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034083003/1
4 years, 6 months ago (2016-06-03 19:50:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/194960)
4 years, 6 months ago (2016-06-03 19:58:50 UTC) #8
Nico
+atwilson for components/policy/OWNERS
4 years, 6 months ago (2016-06-03 20:00:52 UTC) #10
Andrew T Wilson (Slow)
lgtm
4 years, 6 months ago (2016-06-06 13:34:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034083003/1
4 years, 6 months ago (2016-06-06 13:35:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 14:51:51 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 14:53:27 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63c14e06e08bca1d9ca347b6c00d2e444ab212ca
Cr-Commit-Position: refs/heads/master@{#398022}

Powered by Google App Engine
This is Rietveld 408576698