Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1963)

Unified Diff: Source/devtools/front_end/HeapSnapshotCommon.js

Issue 203403002: Show live objects with given allocation call stack (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/HeapSnapshotCommon.js
diff --git a/Source/devtools/front_end/HeapSnapshotCommon.js b/Source/devtools/front_end/HeapSnapshotCommon.js
index 5b6ee3f951ec2bc96040bc4c3509dd57aad1bda0..b99619ae6d68577be518f17ce9db490709e717df 100644
--- a/Source/devtools/front_end/HeapSnapshotCommon.js
+++ b/Source/devtools/front_end/HeapSnapshotCommon.js
@@ -266,6 +266,8 @@ WebInspector.HeapSnapshotCommon.NodeFilter = function(minNodeId, maxNodeId)
this.minNodeId = minNodeId;
/** @type {number|undefined} */
this.maxNodeId = maxNodeId;
+ /** @type {number|undefined} */
+ this.allocationNodeId;
alph 2014/03/18 12:28:22 Looks like there are two distinct filter types: no
yurys 2014/03/18 12:30:47 I will need to filter by both id range and allocat
}
WebInspector.HeapSnapshotCommon.NodeFilter.prototype =
@@ -276,6 +278,6 @@ WebInspector.HeapSnapshotCommon.NodeFilter.prototype =
*/
equals: function(o)
{
- return this.minNodeId === o.minNodeId && this.maxNodeId === o.maxNodeId;
+ return this.minNodeId === o.minNodeId && this.maxNodeId === o.maxNodeId && this.allocationNodeId === o.allocationNodeId;
}
}

Powered by Google App Engine
This is Rietveld 408576698