Issue 203403002: Show live objects with given allocation call stack

Issue 203403002: Show live objects with given allocation call stack (Closed)

Created:
6 years, 9 months ago by yurys

Modified:
6 years, 9 months ago

Reviewers:
alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Show live objects with given allocation call stack When allocation stack trace is selected in the allocation view summary view underneath it is populated with information about live heap objects allocated with that stack trace. BUG=277984 R=alph@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169451

Patch Set 1 #

Total comments: 4

Patch Set 2 : Added more annotations #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -27 lines)			Patch
M	Source/devtools/front_end/AllocationProfile.js	View	1	5 chunks	+31 lines, -10 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshot.js	View	1	3 chunks	+54 lines, -15 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotCommon.js	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotDataGrids.js	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotProxy.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotView.js	View	1	4 chunks	+25 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

alph

lgtm https://codereview.chromium.org/203403002/diff/1/Source/devtools/front_end/AllocationProfile.js File Source/devtools/front_end/AllocationProfile.js (right): https://codereview.chromium.org/203403002/diff/1/Source/devtools/front_end/AllocationProfile.js#newcode178 Source/devtools/front_end/AllocationProfile.js:178: _ensureBottomUpNode: function(nodeId) annotate? https://codereview.chromium.org/203403002/diff/1/Source/devtools/front_end/HeapSnapshotCommon.js File Source/devtools/front_end/HeapSnapshotCommon.js (right): https://codereview.chromium.org/203403002/diff/1/Source/devtools/front_end/HeapSnapshotCommon.js#newcode270 ...

6 years, 9 months ago (2014-03-18 12:28:22 UTC) #2

yurys

https://codereview.chromium.org/203403002/diff/1/Source/devtools/front_end/AllocationProfile.js File Source/devtools/front_end/AllocationProfile.js (right): https://codereview.chromium.org/203403002/diff/1/Source/devtools/front_end/AllocationProfile.js#newcode178 Source/devtools/front_end/AllocationProfile.js:178: _ensureBottomUpNode: function(nodeId) On 2014/03/18 12:28:22, alph wrote: > annotate? ...

6 years, 9 months ago (2014-03-18 12:30:47 UTC) #3

yurys

6 years, 9 months ago (2014-03-18 14:16:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r169451 (presubmit successful).

Expand Messages | Collapse Messages