Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2033993002: Don't call WebCacheManager::Remove(RPH_id) to clear webview's cache. (Closed)

Created:
4 years, 6 months ago by lazyboy
Modified:
4 years, 6 months ago
Reviewers:
lfg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't call WebCacheManager::Remove(RPH_id) to clear webview's cache. We already call WebCacheManager::ClearCacheForProcess(RPH_id), which seems to be sufficient in my local testing. I remember that clearing webview cache didn't seem to work without calling WCM::Remove() when I implemented it. After r380598, Calling WCM::Remove also deletes mojo service associated with the RPH, so the next call to WCM::Remove with the same RPH will result in a nullptr access. BUG=615429 Test=Added a test, see http://crbug.com/615429#c2 for repro. Committed: https://crrev.com/d0dae71f785f35d100d1454e3a7331a896bdf2f2 Cr-Commit-Position: refs/heads/master@{#397803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -1 line) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/web_view/common/cleardata_twice/bootstrap.js View 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/web_view/common/cleardata_twice/guest.html View 1 chunk +41 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
lazyboy
4 years, 6 months ago (2016-06-03 01:18:58 UTC) #2
lfg
lgtm
4 years, 6 months ago (2016-06-03 18:26:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033993002/1
4 years, 6 months ago (2016-06-03 21:14:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 21:20:18 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 21:21:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0dae71f785f35d100d1454e3a7331a896bdf2f2
Cr-Commit-Position: refs/heads/master@{#397803}

Powered by Google App Engine
This is Rietveld 408576698