Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: Source/core/dom/ExecutionContext.h

Issue 203393002: Revert of Explicit notification and removal of lifecycle observers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/ContextLifecycleNotifier.cpp ('k') | Source/core/dom/ExecutionContext.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2012 Google Inc. All Rights Reserved. 3 * Copyright (C) 2012 Google Inc. All Rights Reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 void didChangeTimerAlignmentInterval(); 117 void didChangeTimerAlignmentInterval();
118 118
119 SandboxFlags sandboxFlags() const { return m_sandboxFlags; } 119 SandboxFlags sandboxFlags() const { return m_sandboxFlags; }
120 bool isSandboxed(SandboxFlags mask) const { return m_sandboxFlags & mask; } 120 bool isSandboxed(SandboxFlags mask) const { return m_sandboxFlags & mask; }
121 void enforceSandboxFlags(SandboxFlags mask); 121 void enforceSandboxFlags(SandboxFlags mask);
122 122
123 PassOwnPtr<LifecycleNotifier<ExecutionContext> > createLifecycleNotifier(); 123 PassOwnPtr<LifecycleNotifier<ExecutionContext> > createLifecycleNotifier();
124 124
125 virtual EventQueue* eventQueue() const = 0; 125 virtual EventQueue* eventQueue() const = 0;
126 126
127 void removeAllLifecycleObservers();
128
129 protected: 127 protected:
130 128
131 ContextLifecycleNotifier& lifecycleNotifier(); 129 ContextLifecycleNotifier& lifecycleNotifier();
132 130
133 private: 131 private:
134 friend class DOMTimer; // For installNewTimeout() and removeTimeoutByID() be low. 132 friend class DOMTimer; // For installNewTimeout() and removeTimeoutByID() be low.
135 133
136 bool dispatchErrorEvent(PassRefPtr<ErrorEvent>, AccessControlStatus); 134 bool dispatchErrorEvent(PassRefPtr<ErrorEvent>, AccessControlStatus);
137 135
138 virtual void refExecutionContext() = 0; 136 virtual void refExecutionContext() = 0;
(...skipping 22 matching lines...) Expand all
161 159
162 // The location of this member is important; to make sure contextDestroyed() notification on 160 // The location of this member is important; to make sure contextDestroyed() notification on
163 // ExecutionContext's members (notably m_timeouts) is called before they are destructed, 161 // ExecutionContext's members (notably m_timeouts) is called before they are destructed,
164 // m_lifecycleNotifer should be placed *after* such members. 162 // m_lifecycleNotifer should be placed *after* such members.
165 OwnPtr<ContextLifecycleNotifier> m_lifecycleNotifier; 163 OwnPtr<ContextLifecycleNotifier> m_lifecycleNotifier;
166 }; 164 };
167 165
168 } // namespace WebCore 166 } // namespace WebCore
169 167
170 #endif // ExecutionContext_h 168 #endif // ExecutionContext_h
OLDNEW
« no previous file with comments | « Source/core/dom/ContextLifecycleNotifier.cpp ('k') | Source/core/dom/ExecutionContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698