Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 203393002: Revert of Explicit notification and removal of lifecycle observers. (Closed)

Created:
6 years, 9 months ago by sof
Modified:
6 years, 9 months ago
CC:
blink-reviews, eae+blinkwatch, falken, dglazkov+blink, adamk+blink_chromium.org, Inactive, horo+watch_chromium.org, kinuko+watch, rwlbuis, dcheng
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Explicit notification and removal of lifecycle observers. (https://codereview.chromium.org/194923007/) Reason for revert: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/workers/storage/interrupt-database.html,http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dedicated_worker.html,http/tests/xmlhttprequest/workers/referer.html,http/tests/xmlhttprequest/workers/xmlhttprequest-response-type-blob.html Original issue's description: > Explicit notification and removal of lifecycle observers. > > To help make disposing of execution contexts cleaner in a setting > where both a context and its lifetime observers are being finalized > by a garbage collector, add support for explicitly clearing out > all lifecycle observers: > > protected: > void LifecycleNotifier<T>::removeAndNotifyAllObservers() > > Notifying them that the context has been destroyed while doing so. > An operation that was previously (only) done by the LifecycleNotifier > destructor. > > Also provide a convenience method over ExecutionContext for clearing > out its observers: > > void ExecutionContext::removeAllLifecycleObservers() > > The operation is used here when shutting down and finalizing a worker > thread and its global scope -- explicitly severing the connection > of all observers to its execution context before performing the > final garbage collection. > > Doing so ensures that all observer objects being finalized during that > garbage collection will not have access to its execution context object. > A heap object that may or may not have been finalized by the garbage > collector already. > > R=haraken@chromium.org,ager@chromium.org,abarth@chromium.org > BUG=340522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169435 TBR=oilpan-reviews@chromium.org,abarth@chromium.org,haraken@chromium.org,ager@chromium.org,eseidel@chromium.org,tkent@chromium.org NOTREECHECKS=true NOTRY=true BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -52 lines) Patch
M Source/core/dom/ContextLifecycleNotifier.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/ContextLifecycleNotifier.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +7 lines, -15 lines 0 comments Download
M Source/platform/LifecycleNotifier.h View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Created Revert of Explicit notification and removal of lifecycle observers.
6 years, 9 months ago (2014-03-18 11:54:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/203393002/1
6 years, 9 months ago (2014-03-18 11:54:13 UTC) #2
commit-bot: I haz the power
Change committed as 169444
6 years, 9 months ago (2014-03-18 11:54:31 UTC) #3
haraken
LGTM
6 years, 9 months ago (2014-03-18 11:58:38 UTC) #4
Mads Ager (chromium)
6 years, 9 months ago (2014-03-18 12:02:06 UTC) #5
Message was sent while issue was closed.
LGTM, thanks Sigbjørn.

Powered by Google App Engine
This is Rietveld 408576698