Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 2033893006: mac/gn: Add tests to media_unittests missing in gn build. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac/gn: Add tests to media_unittests missing in gn build. BUG=431177 Committed: https://crrev.com/84a2e9cf24ea01a009e3102521a691a357c0dda3 Cr-Commit-Position: refs/heads/master@{#397817}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M media/BUILD.gn View 1 2 chunks +3 lines, -4 lines 0 comments Download
M media/base/mac/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Nico
4 years, 6 months ago (2016-06-03 19:31:37 UTC) #2
DaleCurtis
lgtm
4 years, 6 months ago (2016-06-03 19:42:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033893006/20001
4 years, 6 months ago (2016-06-03 19:50:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 22:05:56 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 22:09:32 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84a2e9cf24ea01a009e3102521a691a357c0dda3
Cr-Commit-Position: refs/heads/master@{#397817}

Powered by Google App Engine
This is Rietveld 408576698