Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2033883002: Re-enable AppMenuTest#testChangingOrientationHidesMenu() (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable AppMenuTest#testChangingOrientationHidesMenu() BUG=458193 Committed: https://crrev.com/9bb4fadfacdb7962c3865f68370903b15f1fa9f4 Cr-Commit-Position: refs/heads/master@{#397840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pkotwicz
tedchoc@ can you please take a look? I could not reproduce the flakiness locally and ...
4 years, 6 months ago (2016-06-03 00:21:27 UTC) #2
Ted C
lgtm
4 years, 6 months ago (2016-06-03 21:44:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033883002/1
4 years, 6 months ago (2016-06-03 22:05:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 23:34:08 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9bb4fadfacdb7962c3865f68370903b15f1fa9f4 Cr-Commit-Position: refs/heads/master@{#397840}
4 years, 6 months ago (2016-06-03 23:35:46 UTC) #8
dgn
4 years, 5 months ago (2016-06-28 13:51:35 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2108653002/ by dgn@chromium.org.

The reason for reverting is: Flaky again on JB Tester and M Tablet Tester..

Powered by Google App Engine
This is Rietveld 408576698