Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 2033863003: Remove use of deprecated MessageLoop methods in rlz. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of deprecated MessageLoop methods in rlz. MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon are deprecated. This CL makes the following replacements to remove some uses of these methods: "MessageLoop(ForUI|ForIO)::current()->PostTask" -> "ThreadTaskRunnerHandle::Get()->PostTask" "MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" -> "ThreadTaskRunnerHandle::Get()->PostDelayedTask" "MessageLoop(ForUI|ForIO)::current()->DeleteSoon" -> "ThreadTaskRunnerHandle::Get()->DeleteSoon" "MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" -> "ThreadTaskRunnerHandle::Get()->ReleaseSoon" In files where these replacements are made, it adds these includes: #include "base/location.h" #include "base/single_thread_task_runner.h" #include "base/threading/thread_task_runner_handle.h" And removes this include if it is no longer required: #include "base/message_loop/message_loop.h" Why ThreadTaskRunnerHandle::Get() instead of MessageLoop::current()->task_runner()? - The two are equivalent on threads that run a MessageLoop. - MessageLoop::current() doesn't work in base/task_scheduler because the scheduler's thread don't run MessageLoops. This CL will therefore facilitate the migration of browser threads to base/task_scheduler. Steps to generate this patch: 1. Run message_loop_cleanup.py (see code on the bug). 2. Run tools/sort-headers.py on modified files. 3. Run git cl format. BUG=616447 R=rogerta@chromium.org Committed: https://crrev.com/67dc362c2cd49960a466f7765212840db67b5416 Cr-Commit-Position: refs/heads/master@{#398154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M rlz/lib/financial_ping.cc View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-06 16:38:13 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
4 years, 6 months ago (2016-06-06 20:53:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033863003/1
4 years, 6 months ago (2016-06-06 21:48:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 22:58:08 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/67dc362c2cd49960a466f7765212840db67b5416 Cr-Commit-Position: refs/heads/master@{#398154}
4 years, 6 months ago (2016-06-06 23:01:11 UTC) #9
Will Harris
4 years, 6 months ago (2016-06-09 01:20:43 UTC) #10
Message was sent while issue was closed.
On 2016/06/06 23:01:11, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/67dc362c2cd49960a466f7765212840db67b5416
> Cr-Commit-Position: refs/heads/master@{#398154}

this CL is causing a DCHECK to hit - see bug 618530

Powered by Google App Engine
This is Rietveld 408576698