Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: ash/public/interfaces/container.mojom

Issue 2033843003: Makes ash/mus use RootWindowControllerCommon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_mash_wm
Patch Set: merge fail Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/window_manager.cc ('k') | ash/sysui/sysui_application.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/public/interfaces/container.mojom
diff --git a/ash/public/interfaces/container.mojom b/ash/public/interfaces/container.mojom
index 733978e1ebd07cf9a9b58ab761b8ffcae7891be0..e0269a118d6bd7169b0ecb7dbb9f2f5df453a17f 100644
--- a/ash/public/interfaces/container.mojom
+++ b/ash/public/interfaces/container.mojom
@@ -4,43 +4,22 @@
module ash.mojom;
-// Containers for windows. This list is in the z-order of the windows, however
-// they are actually built in a hierarchy (e.g. USER and LOGIN are siblings).
-// See RootWindowController::CreateContainers() for the full hierarchy.
-//
-// NOTE: containers whose name starts with an earlier name are children.
-// For example, USER_BACKGROUND is a child of USER and USER_PRIVATE_WINDOWS is a
-// child of USER_PRIVATE.
+// Containers windows may be parented to.
+// NOTE: this is not the complete list of containers created by ash. See
+// ash/common/shell_window_ids.h for the complete this. This is only a subset
+// that other apps may need to parent windows to.
enum Container {
- ROOT = 0,
- ALL_USER_BACKGROUND,
- USER,
+ // TODO: remove everything but LOGIN_WINDOWS, http://crbug.com/616859.
USER_BACKGROUND,
- // Container that is hidden when screen is locked, child of USER.
- USER_PRIVATE,
- // Windows with no explicit container end up here.
- USER_PRIVATE_WINDOWS,
- USER_PRIVATE_ALWAYS_ON_TOP_WINDOWS,
- USER_PRIVATE_DOCKED_WINDOWS,
- USER_PRIVATE_PRESENTATION_WINDOWS,
USER_PRIVATE_SHELF,
- USER_PRIVATE_PANELS,
- USER_PRIVATE_APP_LIST,
- USER_PRIVATE_SYSTEM_MODAL,
- LOGIN,
LOGIN_WINDOWS,
- LOGIN_APP, // TODO(beng): what about dialog boxes login opens?
- LOGIN_SHELF,
// Status area widget and message center notification popups.
STATUS,
// Bubble windows, for example the sysui system tray bubble and the screen
// brightness bubble.
BUBBLES,
- SYSTEM_MODAL_WINDOWS,
- KEYBOARD,
MENUS,
DRAG_AND_TOOLTIPS,
- COUNT
};
const string kWindowContainer_Property = "ash:window-container";
« no previous file with comments | « ash/mus/window_manager.cc ('k') | ash/sysui/sysui_application.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698