Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2578)

Unified Diff: ash/mus/container_ids.cc

Issue 2033843003: Makes ash/mus use RootWindowControllerCommon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_mash_wm
Patch Set: merge fail Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/container_ids.h ('k') | ash/mus/fill_layout.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/container_ids.cc
diff --git a/ash/mus/container_ids.cc b/ash/mus/container_ids.cc
index 3d95fea3db3e0143f12f1aa4df02e27ec6098539..cd72470742068a4ad82acd9ff9ae320e730e75b8 100644
--- a/ash/mus/container_ids.cc
+++ b/ash/mus/container_ids.cc
@@ -12,139 +12,32 @@ using ash::mojom::Container;
namespace ash {
namespace mus {
-const Container kActivationContainers[] = {
- // TODO(sky): figure out right set of containers. I suspect this should be
- // all non containers.
- Container::USER_PRIVATE_WINDOWS,
- Container::USER_PRIVATE_ALWAYS_ON_TOP_WINDOWS,
- Container::USER_PRIVATE_DOCKED_WINDOWS,
- Container::USER_PRIVATE_PRESENTATION_WINDOWS,
- Container::USER_PRIVATE_PANELS, Container::USER_PRIVATE_APP_LIST,
- Container::USER_PRIVATE_SYSTEM_MODAL, Container::LOGIN,
- // Bubble windows must be allowed to activate because some of them rely on
- // deactivation to close.
- Container::BUBBLES,
-};
-
-const size_t kNumActivationContainers = arraysize(kActivationContainers);
-
-Container AshContainerToMashContainer(int ash_id) {
- switch (ash_id) {
- case kShellWindowId_UnparentedControlContainer:
- case kShellWindowId_LockScreenContainer:
- case kShellWindowId_LockSystemModalContainer:
- // We should never be asked to parent windows of these types.
- NOTREACHED();
- return Container::USER_PRIVATE;
-
- case kShellWindowId_DefaultContainer:
- return Container::USER_PRIVATE_WINDOWS;
-
- case kShellWindowId_AlwaysOnTopContainer:
- return Container::USER_PRIVATE_ALWAYS_ON_TOP_WINDOWS;
-
- case kShellWindowId_DockedContainer:
- return Container::USER_PRIVATE_DOCKED_WINDOWS;
-
- case kShellWindowId_ShelfContainer:
- return Container::USER_PRIVATE_SHELF;
-
- case kShellWindowId_PanelContainer:
- return Container::USER_PRIVATE_PANELS;
-
- case kShellWindowId_AppListContainer:
- return Container::USER_PRIVATE_APP_LIST;
-
- case kShellWindowId_SystemModalContainer:
- return Container::USER_PRIVATE_SYSTEM_MODAL;
-
- case kShellWindowId_MenuContainer:
- return Container::MENUS;
-
- case kShellWindowId_DragImageAndTooltipContainer:
- return Container::DRAG_AND_TOOLTIPS;
-
- default:
- NOTREACHED();
- }
- return Container::USER_PRIVATE_WINDOWS;
-}
-
-int MashContainerToAshContainer(Container container) {
+int MashContainerToAshShellWindowId(Container container) {
switch (container) {
- case Container::ROOT:
- return kUnknownAshId;
-
- case Container::ALL_USER_BACKGROUND:
- return kUnknownAshId;
-
- case Container::USER:
- return kUnknownAshId;
-
case Container::USER_BACKGROUND:
- return kUnknownAshId;
-
- case Container::USER_PRIVATE:
- return kUnknownAshId;
-
- case Container::USER_PRIVATE_WINDOWS:
- return kShellWindowId_DefaultContainer;
-
- case Container::USER_PRIVATE_ALWAYS_ON_TOP_WINDOWS:
- return kShellWindowId_AlwaysOnTopContainer;
-
- case Container::USER_PRIVATE_DOCKED_WINDOWS:
- return kShellWindowId_DockedContainer;
-
- case Container::USER_PRIVATE_PRESENTATION_WINDOWS:
- return kUnknownAshId;
+ return kShellWindowId_DesktopBackgroundContainer;
case Container::USER_PRIVATE_SHELF:
return kShellWindowId_ShelfContainer;
- case Container::USER_PRIVATE_PANELS:
- return kShellWindowId_PanelContainer;
-
- case Container::USER_PRIVATE_APP_LIST:
- return kShellWindowId_AppListContainer;
-
- case Container::USER_PRIVATE_SYSTEM_MODAL:
- return kShellWindowId_SystemModalContainer;
-
- case Container::LOGIN:
- return kUnknownAshId;
-
case Container::LOGIN_WINDOWS:
- return kUnknownAshId;
-
- case Container::LOGIN_APP:
- return kUnknownAshId;
-
- case Container::LOGIN_SHELF:
- return kUnknownAshId;
+ return kShellWindowId_LockScreenContainer;
case Container::STATUS:
- return kUnknownAshId;
+ return kShellWindowId_StatusContainer;
case Container::BUBBLES:
- return kUnknownAshId;
-
- case Container::SYSTEM_MODAL_WINDOWS:
- return kUnknownAshId;
-
- case Container::KEYBOARD:
- return kUnknownAshId;
+ // TODO(sky): this mapping isn't right, but BUBBLES should go away once
+ // http://crbug.com/616859 lands.
+ return kShellWindowId_SettingBubbleContainer;
case Container::MENUS:
return kShellWindowId_MenuContainer;
case Container::DRAG_AND_TOOLTIPS:
return kShellWindowId_DragImageAndTooltipContainer;
-
- case Container::COUNT:
- return kUnknownAshId;
}
- return kUnknownAshId;
+ return kShellWindowId_Invalid;
}
} // namespace mus
« no previous file with comments | « ash/mus/container_ids.h ('k') | ash/mus/fill_layout.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698