ash: Remove aura dependencies from ash/system/web_notification

ash: Remove aura dependencies from ash/system/web_notification

* Switch to common wm:WmWindow types.
* Convert unit tests to use views::Widget instead of aura::Window

No functional changes.

TODO: Figure out how to set window parents in ui/message_center without
using aura.

BUG=615155
TEST=existing ash_unittests

Committed: https://crrev.com/8a10a2b2511632f20fc822b2ac4bd78d0c2032d2
Cr-Commit-Position: refs/heads/master@{#397587}

[James Cook, 2016-06-02 18:01:28]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-06-02 18:01:29]

sky, please take a look.

https://codereview.chromium.org/2033833002/diff/1/ash/system/web_notification...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/2033833002/diff/1/ash/system/web_notification...
ash/system/web_notification/web_notification_tray.cc:217:
ash::Shell::GetContainer(
I'm not sure what to do about this. MessagePopupCollection needs to be able to
parent windows to a container, but it lives in ui/message_center/views.

[sky, 2016-06-02 18:15:59]

LGTM

https://codereview.chromium.org/2033833002/diff/1/ash/system/web_notification...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/2033833002/diff/1/ash/system/web_notification...
ash/system/web_notification/web_notification_tray.cc:217:
ash::Shell::GetContainer(
On 2016/06/02 18:01:29, James Cook wrote:
> I'm not sure what to do about this. MessagePopupCollection needs to be able to
> parent windows to a container, but it lives in ui/message_center/views.

I'm not familiar enough with message_center to say. If this MessageCenter is
only used internal to ash, then making it know about mus sounds right.

[James Cook, 2016-06-02 19:42:20]

https://codereview.chromium.org/2033833002/diff/1/ash/system/web_notification...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/2033833002/diff/1/ash/system/web_notification...
ash/system/web_notification/web_notification_tray.cc:217:
ash::Shell::GetContainer(
On 2016/06/02 18:15:59, sky wrote:
> On 2016/06/02 18:01:29, James Cook wrote:
> > I'm not sure what to do about this. MessagePopupCollection needs to be able
to
> > parent windows to a container, but it lives in ui/message_center/views.
> 
> I'm not familiar enough with message_center to say. If this MessageCenter is
> only used internal to ash, then making it know about mus sounds right.

Unfortunately it is shared with desktop Chrome for showing notifications.
Desktop Chrome does not provide a parent container, since these are shown over
the desktop.  I might be able to do something like:

* Pass an integer container_id into here.
* Add a client interface somewhere in //ui/views that can convert a container_id
into a void* parent.
* Depending on whether or not mus is running, cast the void* parent to either an
aura::Window (and assign to Widget::InitParams::parent) or to a mus::Window (and
assign to Widget::InitParams::parent_mus).

But that seems pretty distasteful.

I'm going to leave it alone for now, unless you see an obvious solution.

[James Cook, 2016-06-02 19:42:27]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-06-02 19:43:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033833002/1

[sky, 2016-06-02 21:49:05]

Leave it for now is fine by me. I would make sure to log a bug if you
haven't already.

On Thu, Jun 2, 2016 at 12:42 PM,  <jamescook@chromium.org> wrote:
>
>
https://codereview.chromium.org/2033833002/diff/1/ash/system/web_notification...
> File ash/system/web_notification/web_notification_tray.cc (right):
>
>
https://codereview.chromium.org/2033833002/diff/1/ash/system/web_notification...
> ash/system/web_notification/web_notification_tray.cc:217:
> ash::Shell::GetContainer(
> On 2016/06/02 18:15:59, sky wrote:
>> On 2016/06/02 18:01:29, James Cook wrote:
>> > I'm not sure what to do about this. MessagePopupCollection needs to
> be able to
>> > parent windows to a container, but it lives in
> ui/message_center/views.
>>
>> I'm not familiar enough with message_center to say. If this
> MessageCenter is
>> only used internal to ash, then making it know about mus sounds right.
>
> Unfortunately it is shared with desktop Chrome for showing
> notifications. Desktop Chrome does not provide a parent container, since
> these are shown over the desktop. I might be able to do something like:
>
> * Pass an integer container_id into here.
> * Add a client interface somewhere in //ui/views that can convert a
> container_id into a void* parent.
> * Depending on whether or not mus is running, cast the void* parent to
> either an aura::Window (and assign to Widget::InitParams::parent) or to
> a mus::Window (and assign to Widget::InitParams::parent_mus).
>
> But that seems pretty distasteful.
>
> I'm going to leave it alone for now, unless you see an obvious solution.
>
> https://codereview.chromium.org/2033833002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-06-02 23:07:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 23:07:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-06-02 23:17:27]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-06-02 23:18:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033833002/1

[commit-bot: I haz the power, 2016-06-03 02:35:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-03 02:37:13]

Description was changed from

==========
ash: Remove aura dependencies from ash/system/web_notification

* Switch to common wm:WmWindow types.
* Convert unit tests to use views::Widget instead of aura::Window

No functional changes.

TODO: Figure out how to set window parents in ui/message_center without
using aura.

BUG=615155
TEST=existing ash_unittests
==========

to

==========
ash: Remove aura dependencies from ash/system/web_notification

* Switch to common wm:WmWindow types.
* Convert unit tests to use views::Widget instead of aura::Window

No functional changes.

TODO: Figure out how to set window parents in ui/message_center without
using aura.

BUG=615155
TEST=existing ash_unittests

Committed: https://crrev.com/8a10a2b2511632f20fc822b2ac4bd78d0c2032d2
Cr-Commit-Position: refs/heads/master@{#397587}
==========

[commit-bot: I haz the power, 2016-06-03 02:37:15]

Patchset 1 (id:??) landed as
https://crrev.com/8a10a2b2511632f20fc822b2ac4bd78d0c2032d2
Cr-Commit-Position: refs/heads/master@{#397587}