Issue 203383005: in progress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203383005: in progress (Closed)

Created:
6 years, 9 months ago by szager1

Modified:
6 years, 9 months ago

Reviewers:
iannucci, M-A Ruel, ghost stip (do not use)

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Fix push-basic.sh. How did it ever pass? We may never know. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=257738

Patch Set 2 : #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tests/push-basic.sh	View	1	1 chunk	+1 line, -1 line	1 comment	Download
	M	tests/test-lib.sh	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

iannucci

"lgtm" for now. I filed a bug for push-basic here: https://code.google.com/p/chromium/issues/detail?id=353718 https://codereview.chromium.org/203383005/diff/20001/tests/push-basic.sh File tests/push-basic.sh (right): ...

6 years, 9 months ago (2014-03-18 20:38:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/203383005/20001

6 years, 9 months ago (2014-03-18 20:43:43 UTC) #4

Message was sent while issue was closed.

Change committed as 257738

Expand Messages | Collapse Messages

Issue 203383005: in progress (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages