Issue 203383003: Support building selected C/C++ files in msvs-ninja

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203383003: Support building selected C/C++ files in msvs-ninja (Closed)

Created:
6 years, 9 months ago by Shezan Baig (Bloomberg)

Modified:
6 years, 9 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Support building selected C/C++ files in msvs-ninja This commits adds a new 'msvs_external_builder_clcompile_cmd' property, which will be used when the user tries building selected C/C++ files. For msvs-ninja, the 'msvs_external_builder_clcompile_cmd' will be mapped to a new 'ExecClCompile' command in gyp-win-tool, which will expand the list of selected files into a list of ninja targets and then invoke ninja. BUG=352876 R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1878

Patch Set 1 #

Total comments: 1

Patch Set 2 : use BASEDIR #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -2 lines)			Patch
	M	pylib/gyp/generator/msvs.py	View		4 chunks	+23 lines, -2 lines	0 comments	Download
	M	pylib/gyp/win_tool.py	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Shezan Baig (Bloomberg)

I'm not sure how to test this. Devenv.exe doesn't seem to have an automated way ...

6 years, 9 months ago (2014-03-18 15:03:28 UTC) #1

scottmg

LGTM with that. Thanks! https://codereview.chromium.org/203383003/diff/1/pylib/gyp/win_tool.py File pylib/gyp/win_tool.py (right): https://codereview.chromium.org/203383003/diff/1/pylib/gyp/win_tool.py#newcode306 pylib/gyp/win_tool.py:306: project_dir = os.path.relpath(project_dir, build_dir) BASEDIR ...

6 years, 9 months ago (2014-03-18 17:04:12 UTC) #2

Shezan Baig (Bloomberg)

6 years, 9 months ago (2014-03-19 14:53:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r1878 (presubmit successful).

Expand Messages | Collapse Messages