Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: gni/isolate.gni

Issue 2033813004: [gn] Add swarming support for all test targets (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@gn32
Patch Set: Fixes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/isolate.gni
diff --git a/gni/isolate.gni b/gni/isolate.gni
index ac1bb79e2935f0e7c2caa11d6272ab7a765778bb..9f29556ef866bb2198f9de1fc0f031a903f1b1ac 100644
--- a/gni/isolate.gni
+++ b/gni/isolate.gni
@@ -17,9 +17,11 @@ template("v8_isolate_run") {
if (name != "" && invoker.isolate != "" && invoker.deps != [] &&
v8_test_isolation_mode != "noop") {
action(name + "_run") {
+ testonly = true
+
deps = invoker.deps
- script = "tools/isolate_driver.py"
+ script = "//tools/isolate_driver.py"
sources = [
invoker.isolate,
@@ -27,13 +29,20 @@ template("v8_isolate_run") {
inputs = [
# Files that are known to be involved in this step.
- "tools/swarming_client/isolate.py",
- "tools/swarming_client/run_isolated.py",
+ "//tools/swarming_client/isolate.py",
+ "//tools/swarming_client/run_isolated.py",
]
- outputs = [
- "$root_out_dir/$name.isolated",
- ]
+ if (v8_test_isolation_mode == "prepare") {
+ outputs = [
+ "$root_out_dir/$name.isolated.gen.json",
+ ]
+ } else if (v8_test_isolation_mode == "check") {
+ outputs = [
+ "$root_out_dir/$name.isolated",
+ "$root_out_dir/$name.isolated.state",
+ ]
+ }
# Translate gn to gyp variables.
if (is_asan) {
« no previous file with comments | « BUILD.gn ('k') | test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698