Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2033773002: headless: Migrate to URLRequestContextBuilder (Closed)

Created:
4 years, 6 months ago by Sami
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Migrate to URLRequestContextBuilder Migrate to using URLRequestContextBuilder, which lets us remove a lot of redundant network setup code. BUG=616475 Committed: https://crrev.com/322875f4d93696a3d789151e5a385cafbdcf9f69 Cr-Commit-Position: refs/heads/master@{#397673}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -173 lines) Patch
M headless/lib/browser/headless_browser_context.cc View 1 chunk +1 line, -3 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.h View 3 chunks +0 lines, -12 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.cc View 2 chunks +33 lines, -158 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
4 years, 6 months ago (2016-06-02 14:48:37 UTC) #3
alex clarke (OOO till 29th)
lgtm
4 years, 6 months ago (2016-06-03 09:32:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033773002/20001
4 years, 6 months ago (2016-06-03 09:32:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 10:13:29 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 10:14:40 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/322875f4d93696a3d789151e5a385cafbdcf9f69
Cr-Commit-Position: refs/heads/master@{#397673}

Powered by Google App Engine
This is Rietveld 408576698