Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 203373004: Mojo: Move mojo/system/embedder to mojo/embedder. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update to sky's change #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1277 lines) Patch
M content/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/mojo/mojo_channel_init.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/multiprocess_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/multiprocess_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/multiprocess_test_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/run_all_perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/test_utils_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/test/test_utils_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/embedder/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A mojo/embedder/README.md View 1 chunk +13 lines, -0 lines 0 comments Download
A + mojo/embedder/embedder.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/embedder/embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/embedder/embedder_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/embedder/platform_channel_pair.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/embedder/platform_channel_pair.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/embedder/platform_channel_pair_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/embedder/platform_channel_pair_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/embedder/platform_handle.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/embedder/platform_handle.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/embedder/scoped_platform_handle.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/embedder/test_embedder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/embedder/test_embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo.gyp View 4 chunks +12 lines, -12 lines 0 comments Download
M mojo/shell/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/child_process.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/child_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/child_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/context.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/channel.h View 1 chunk +1 line, -1 line 0 comments Download
D mojo/system/embedder/embedder.h View 1 chunk +0 lines, -56 lines 0 comments Download
D mojo/system/embedder/embedder.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D mojo/system/embedder/embedder_unittest.cc View 1 chunk +0 lines, -508 lines 0 comments Download
D mojo/system/embedder/platform_channel_pair.h View 1 chunk +0 lines, -89 lines 0 comments Download
D mojo/system/embedder/platform_channel_pair.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/system/embedder/platform_channel_pair_posix.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D mojo/system/embedder/platform_channel_pair_win.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D mojo/system/embedder/platform_handle.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/system/embedder/platform_handle.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/system/embedder/scoped_platform_handle.h View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/system/embedder/test_embedder.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/system/embedder/test_embedder.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/raw_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/raw_channel_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/raw_channel_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/system/raw_channel_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/remote_message_pipe_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
I'll let you land your change first, and update my change to match....
6 years, 9 months ago (2014-03-18 17:59:37 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-18 18:08:19 UTC) #2
viettrungluu
content OWNERS TBR -> darin
6 years, 9 months ago (2014-03-18 19:10:26 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-18 19:10:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/203373004/40001
6 years, 9 months ago (2014-03-18 19:21:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 21:41:14 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=85792
6 years, 9 months ago (2014-03-18 21:41:18 UTC) #7
viettrungluu
6 years, 9 months ago (2014-03-19 00:05:40 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 manually as r257820 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698