Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2033723003: Add a test to verify that enabling ImeThread can avoid crash after paste (Closed)

Created:
4 years, 6 months ago by yabinh
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome can crash if pasting long text into textarea, because there is an overflow bug in SpannableStringBuilder#replace(). If ImeThread is enabled, we don't need to call the above function. Thus, we can get rid of that bug. BUG=606059 Committed: https://crrev.com/bd10c315594d2a20e31a94a7a6c7adb9a0961c56 Cr-Commit-Position: refs/heads/master@{#399850}

Patch Set 1 #

Patch Set 2 : remove some redundant code. #

Total comments: 1

Patch Set 3 : a small change for changwan's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 2 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
yabinh
4 years, 6 months ago (2016-06-03 12:47:21 UTC) #3
aelias_OOO_until_Jul13
lgtm
4 years, 6 months ago (2016-06-03 19:43:41 UTC) #6
Changwan Ryu
lgtm https://codereview.chromium.org/2033723003/diff/20001/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/2033723003/diff/20001/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java#newcode633 content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:633: int textLength = 25000; nit: according to stackoverflow, ...
4 years, 6 months ago (2016-06-07 00:31:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033723003/30001
4 years, 6 months ago (2016-06-15 05:09:58 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 6 months ago (2016-06-15 05:40:42 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 05:40:47 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 05:43:47 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bd10c315594d2a20e31a94a7a6c7adb9a0961c56
Cr-Commit-Position: refs/heads/master@{#399850}

Powered by Google App Engine
This is Rietveld 408576698