Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2033723002: NTPSnippetsDatabase: support multiple concurrent loads (Closed)

Created:
4 years, 6 months ago by Marc Treib
Modified:
4 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, zine-eng+reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@leveldb
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTPSnippetsDatabase: support multiple concurrent loads (follow-up to https://codereview.chromium.org/1987333003) So far, there are no multiple loads (yet), but this removes a weird wrinkle from the API and doesn't really make anything any more complex. BUG=605870 Committed: https://crrev.com/65f9bbedd611ba2fb9b1156014518111de3abf77 Cr-Commit-Position: refs/heads/master@{#397662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M components/ntp_snippets/ntp_snippets_database.h View 4 chunks +6 lines, -6 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_database.cc View 4 chunks +10 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
Marc Treib
4 years, 6 months ago (2016-06-02 12:37:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033723002/1
4 years, 6 months ago (2016-06-02 12:37:37 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-02 14:15:17 UTC) #6
Bernhard Bauer
lgtm
4 years, 6 months ago (2016-06-03 08:09:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033723002/1
4 years, 6 months ago (2016-06-03 08:10:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 08:13:52 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 08:16:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65f9bbedd611ba2fb9b1156014518111de3abf77
Cr-Commit-Position: refs/heads/master@{#397662}

Powered by Google App Engine
This is Rietveld 408576698