Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 2033713002: Implement the Chrome Sign-in promo bubble for password manager on Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
index 728300213eef2336c282e575688feae7540e1fae..6620362e234028a890c0149edc8f35363f159ef7 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
@@ -268,6 +268,7 @@ ManagePasswordsBubbleModel::ManagePasswordsBubbleModel(
case password_manager::ui::CONFIRMATION_STATE:
case password_manager::ui::CREDENTIAL_REQUEST_STATE:
case password_manager::ui::AUTO_SIGNIN_STATE:
+ case password_manager::ui::CHROME_SIGN_IN_PROMO_STATE:
case password_manager::ui::INACTIVE_STATE:
NOTREACHED();
break;
@@ -290,6 +291,7 @@ ManagePasswordsBubbleModel::ManagePasswordsBubbleModel(
break;
case password_manager::ui::MANAGE_STATE:
case password_manager::ui::CREDENTIAL_REQUEST_STATE:
+ case password_manager::ui::CHROME_SIGN_IN_PROMO_STATE:
case password_manager::ui::INACTIVE_STATE:
NOTREACHED();
break;
@@ -393,6 +395,14 @@ void ManagePasswordsBubbleModel::OnPasswordAction(
password_store->AddLogin(password_form);
}
+void ManagePasswordsBubbleModel::OnSignInToChromeClicked() {
+
+}
+
+void ManagePasswordsBubbleModel::OnSkipSignInClicked() {
+
+}
+
Profile* ManagePasswordsBubbleModel::GetProfile() const {
return GetProfileFromWebContents(web_contents());
}
@@ -413,6 +423,17 @@ bool ManagePasswordsBubbleModel::ShouldShowGoogleSmartLockWelcome() const {
return false;
}
+bool ManagePasswordsBubbleModel::ReplaceToShowSignInPromoIfNeeded() {
+ DCHECK_EQ(password_manager::ui::PENDING_PASSWORD_STATE, state_);
+ if (false /*TODO(crbug.com/615825): there will be a real condition soon*/) {
+ title_brand_link_range_ = gfx::Range();
+ title_ = l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_SIGNIN_PROMO_TITLE);
+ state_ = password_manager::ui::CHROME_SIGN_IN_PROMO_STATE;
+ return true;
+ }
+ return false;
+}
+
void ManagePasswordsBubbleModel::SetClockForTesting(
std::unique_ptr<base::Clock> clock) {
interaction_keeper_->SetClockForTesting(std::move(clock));

Powered by Google App Engine
This is Rietveld 408576698