Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2033703002:
[compiler] Deal with some old TODOs in the typer. (Closed)
Description[compiler] Deal with some old TODOs in the typer.
This is mostly about DCHECKs. Enabling some requires a few
changes to tests that were not careful about types.
BUG=
Committed: https://crrev.com/6ddd8314a58cfc0af48dba9c991649a0d2bbc02e
Cr-Commit-Position: refs/heads/master@{#36734}
Patch Set 1 : #Patch Set 2 : Rebase #Patch Set 3 : Comment one out again #Patch Set 4 : another one #
Messages
Total messages: 28 (17 generated)
Description was changed from ========== gsave gsave BUG= ========== to ========== BUG= ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033703002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033703002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16379)
Description was changed from ========== BUG= ========== to ========== [compiler] Deal with some old TODOs in the typer. This was mostly about DCHECKs. Enabling some required a few changes to tests that were not careful about types. BUG= ==========
neis@chromium.org changed reviewers: + jarin@chromium.org
Description was changed from ========== [compiler] Deal with some old TODOs in the typer. This was mostly about DCHECKs. Enabling some required a few changes to tests that were not careful about types. BUG= ========== to ========== [compiler] Deal with some old TODOs in the typer. This was mostly about DCHECKs. Enabling some required a few changes to tests that were not careful about types. BUG= ==========
Description was changed from ========== [compiler] Deal with some old TODOs in the typer. This was mostly about DCHECKs. Enabling some required a few changes to tests that were not careful about types. BUG= ========== to ========== [compiler] Deal with some old TODOs in the typer. This is mostly about DCHECKs. Enabling some requires a few changes to tests that were not careful about types. BUG= ==========
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033703002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033703002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/6633) v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033703002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ptal
lgtm. Thanks!
The CQ bit was checked by neis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033703002/120001
Message was sent while issue was closed.
Description was changed from ========== [compiler] Deal with some old TODOs in the typer. This is mostly about DCHECKs. Enabling some requires a few changes to tests that were not careful about types. BUG= ========== to ========== [compiler] Deal with some old TODOs in the typer. This is mostly about DCHECKs. Enabling some requires a few changes to tests that were not careful about types. BUG= ==========
Message was sent while issue was closed.
Committed patchset #4 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== [compiler] Deal with some old TODOs in the typer. This is mostly about DCHECKs. Enabling some requires a few changes to tests that were not careful about types. BUG= ========== to ========== [compiler] Deal with some old TODOs in the typer. This is mostly about DCHECKs. Enabling some requires a few changes to tests that were not careful about types. BUG= Committed: https://crrev.com/6ddd8314a58cfc0af48dba9c991649a0d2bbc02e Cr-Commit-Position: refs/heads/master@{#36734} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/6ddd8314a58cfc0af48dba9c991649a0d2bbc02e Cr-Commit-Position: refs/heads/master@{#36734} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
