Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2033693005: [tools/perf] Move system_health_stories to system_health.loading_stories module (Closed)

Created:
4 years, 6 months ago by nednguyen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, rnephew (Reviews Here)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Move system_health_stories to system_health.loading_stories module Rationale: we know that it's almost impossible to have 1 single system_health story set, hence the current direction is to create multiple stories set for key user actions. In the future, the page_sets/system_health_stories/ folder can contain these extra story_sets: loading scrolling & animation multi_tabs ... BUG=615382, 589726 Committed: https://crrev.com/0087d3d5b48bcda9d7173769369c344e33f205c7 Cr-Commit-Position: refs/heads/master@{#397692}

Patch Set 1 #

Patch Set 2 : Add __init__ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -362 lines) Patch
A + tools/perf/page_sets/system_health/__init__.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/perf/page_sets/system_health/loading_stories.py View 2 chunks +3 lines, -2 lines 0 comments Download
D tools/perf/page_sets/system_health_stories.py View 1 chunk +0 lines, -358 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
nednguyen
4 years, 6 months ago (2016-06-03 01:52:52 UTC) #3
nednguyen
On 2016/06/03 01:52:52, nednguyen wrote: PTAL
4 years, 6 months ago (2016-06-03 01:53:08 UTC) #4
kouhei (in TOK)
lgtm
4 years, 6 months ago (2016-06-03 02:00:17 UTC) #5
petrcermak
I'm fine with this, but I think you need to update the system health benchmark ...
4 years, 6 months ago (2016-06-03 09:04:09 UTC) #6
petrcermak
I'm fine with this, but I think you need to update the system health benchmark ...
4 years, 6 months ago (2016-06-03 09:04:09 UTC) #7
nednguyen
On 2016/06/03 09:04:09, petrcermak wrote: > I'm fine with this, but I think you need ...
4 years, 6 months ago (2016-06-03 11:39:39 UTC) #8
petrcermak
Cool! LGTM. Thanks, Petr
4 years, 6 months ago (2016-06-03 11:53:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033693005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033693005/20001
4 years, 6 months ago (2016-06-03 12:56:03 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 12:59:45 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 13:02:26 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0087d3d5b48bcda9d7173769369c344e33f205c7
Cr-Commit-Position: refs/heads/master@{#397692}

Powered by Google App Engine
This is Rietveld 408576698