Issue 2033693003: ExitDetector: Do not special case enums, since null exists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2033693003: ExitDetector: Do not special case enums, since null exists (Closed)

Created:
4 years, 6 months ago by srawlins

Modified:
4 years, 6 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

ExitDetector: Do not special case enums, since null exists BUG=https://github.com/dart-lang/sdk/issues/26606 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/c2f04d2dc231866b7505660dc9df2cc7a967545b

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -14 lines)			Patch
	M	pkg/analyzer/lib/src/generated/resolver.dart	View		1 chunk	+1 line, -12 lines	0 comments	Download
	M	pkg/analyzer/test/generated/all_the_rest_test.dart	View		2 chunks	+18 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

srawlins

Last fix for the ExitDetector before enabling it for DEAD_CODE detection.

4 years, 6 months ago (2016-06-02 19:16:44 UTC) #2

srawlins

4 years, 6 months ago (2016-06-02 21:15:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c2f04d2dc231866b7505660dc9df2cc7a967545b (presubmit successful).