Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2033683002: [Android] Specify compositor tab title size in scaled pixels. (Closed)

Created:
4 years, 6 months ago by Bernhard Bauer
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, zine-eng+reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Specify compositor tab title size in scaled pixels. This lets Resources do the size calculations, and also fixes an issue where the font scaling factor would be applied twice for >600dp screens (chrome/android/java/res/values-sw600dp/dimens.xml already specifies the size in sp). Committed: https://crrev.com/d8fc0811331ba747d8276f6d3ebc206753544e12 Cr-Commit-Position: refs/heads/master@{#398283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/android/java/res/values/dimens.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TitleBitmapFactory.java View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Bernhard Bauer
Please review. Thanks!
4 years, 6 months ago (2016-06-02 10:35:15 UTC) #3
David Trainor- moved to gerrit
lgtm
4 years, 6 months ago (2016-06-06 21:12:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033683002/1
4 years, 6 months ago (2016-06-07 12:08:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 13:04:32 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 13:06:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8fc0811331ba747d8276f6d3ebc206753544e12
Cr-Commit-Position: refs/heads/master@{#398283}

Powered by Google App Engine
This is Rietveld 408576698