Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2033673002: Remove dead code in CFGAS_FontMgrImp. (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@rm_ifx_font
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove dead code in CFGAS_FontMgrImp. And also CFGAS_StdFontMgrImp. Committed: https://pdfium.googlesource.com/pdfium/+/a7c03c678dbd6fd4732e0cfb390cc4f462434441

Patch Set 1 #

Patch Set 2 : Remove more dead code #

Patch Set 3 : Remove even more dead code #

Patch Set 4 : Be consistent with LoadFontInternal #

Patch Set 5 : Remove more dead code #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -271 lines) Patch
M xfa/fgas/font/fgas_font.h View 1 2 3 4 5 2 chunks +0 lines, -13 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.h View 1 2 3 4 5 2 chunks +7 lines, -11 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 1 2 3 4 5 8 chunks +14 lines, -52 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.h View 1 2 3 4 5 7 chunks +4 lines, -29 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 1 2 3 4 5 15 chunks +7 lines, -165 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Lei Zhang
There may be even more dead code, but this is a good chunk. See diffs ...
4 years, 6 months ago (2016-06-08 00:43:26 UTC) #5
dsinclair
lgtm
4 years, 6 months ago (2016-06-08 01:30:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033673002/160001
4 years, 6 months ago (2016-06-08 01:30:40 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 01:48:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #7 (id:160001) as
https://pdfium.googlesource.com/pdfium/+/a7c03c678dbd6fd4732e0cfb390cc4f46243...

Powered by Google App Engine
This is Rietveld 408576698