Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2033583007: Store ScriptWrappableVisitor in V8PerIsolateData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use unique_ptr instead Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
index f2c049db85f3b606f91f425b876d1cb1ad19f2a5..8fe62e43c0323c1d7f599029e2f2416dad74d37a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
@@ -291,6 +291,7 @@ static void initializeV8Common(v8::Isolate* isolate)
isolate->AddGCEpilogueCallback(V8GCController::gcEpilogue);
if (RuntimeEnabledFeatures::traceWrappablesEnabled()) {
ScriptWrappableVisitor* visitor = new ScriptWrappableVisitor(isolate);
+ V8PerIsolateData::from(isolate)->setScriptWrappableVisitor(visitor);
isolate->SetEmbedderHeapTracer(visitor);
haraken 2016/06/03 12:32:06 unique_ptr<ScriptWrappableVisitor> visitor = new .
}
@@ -371,6 +372,7 @@ void V8Initializer::shutdownMainThread()
{
ASSERT(isMainThread());
v8::Isolate* isolate = V8PerIsolateData::mainThreadIsolate();
+ isolate->SetEmbedderHeapTracer(nullptr);
V8PerIsolateData::willBeDestroyed(isolate);
V8PerIsolateData::destroy(isolate);
}

Powered by Google App Engine
This is Rietveld 408576698