Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2033583002: Implement gfx::Vector2d and gfx::Vector2dF StructTraits (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, sadrul
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement gfx::Vector2d and gfx::Vector2dF StructTraits These are needed for cc::CompositorFrameMetadata BUG=611802 Committed: https://crrev.com/77496f83b63ec714f9593e260a2f7e4eeeed7613 Cr-Commit-Position: refs/heads/master@{#397607}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebased #

Patch Set 4 : Remove unnecessary deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M ui/gfx/geometry/mojo/geometry.mojom View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/gfx/geometry/mojo/geometry.typemap View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gfx/geometry/mojo/geometry_struct_traits.h View 1 2 2 chunks +24 lines, -0 lines 0 comments Download
M ui/gfx/geometry/mojo/geometry_struct_traits_unittest.cc View 1 2 2 chunks +32 lines, -0 lines 0 comments Download
M ui/gfx/geometry/mojo/geometry_traits_test_service.mojom View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Fady Samuel
+sadrul@ for ui/ +tsepez@ for ipc
4 years, 6 months ago (2016-06-02 02:06:53 UTC) #2
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-02 19:10:40 UTC) #3
sadrul
lgtm
4 years, 6 months ago (2016-06-02 19:26:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033583002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033583002/60001
4 years, 6 months ago (2016-06-03 00:46:14 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-03 02:57:40 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 02:59:20 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/77496f83b63ec714f9593e260a2f7e4eeeed7613
Cr-Commit-Position: refs/heads/master@{#397607}

Powered by Google App Engine
This is Rietveld 408576698