Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/views/view.h

Issue 2033553003: Add MD ink drop ripple to shelf app items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ash/shelf/shelf_view_unittest.cc ('K') | « ui/views/controls/button/custom_button.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/view.h
diff --git a/ui/views/view.h b/ui/views/view.h
index 6b45c6313baf3bee9f08047d3891e28b35de22d1..327243e9b16e55d430199902418176115d4ea15f 100644
--- a/ui/views/view.h
+++ b/ui/views/view.h
@@ -323,6 +323,11 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,
// . SetPaintToLayer(true) has been invoked.
// View creates the Layer only when it exists in a Widget with a non-NULL
// Compositor.
+ // TODO(mohsen): Consider making this robust against multiple places changing
+ // it at the same time. For example, class A might set this to true, then
+ // class B sets it to true. Then if class A sets it to false, the layer would
+ // be destroyed and class B might run into problems assuming it is still
+ // painting to layer.
void SetPaintToLayer(bool paint_to_layer);
// Overridden from ui::LayerOwner:
« ash/shelf/shelf_view_unittest.cc ('K') | « ui/views/controls/button/custom_button.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698