Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Issue 2033543002: Wire up class hierarchy for recursive inheritance (Closed)

Created:
4 years, 6 months ago by Leaf
Modified:
4 years, 6 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -143 lines) Patch
M lib/runtime/dart_sdk.js View 1 chunk +2 lines, -1 line 0 comments Download
A test/codegen/language/recursive_inheritance_test.dart View 1 1 chunk +24 lines, -0 lines 0 comments Download
A + test/codegen/language/type_hoisting_test.dart View 1 2 3 3 chunks +6 lines, -10 lines 0 comments Download
A + test/codegen/language/type_no_hoisting_test.dart View 1 2 3 3 chunks +6 lines, -10 lines 0 comments Download
D test/codegen/type_hoisting.dart View 1 1 chunk +0 lines, -60 lines 0 comments Download
D test/codegen/type_no_hoisting.dart View 1 1 chunk +0 lines, -60 lines 0 comments Download
M test/codegen_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/private/ddc_runtime/classes.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Leaf
4 years, 6 months ago (2016-06-02 02:15:47 UTC) #2
Jacob
lgtm
4 years, 6 months ago (2016-06-02 02:18:36 UTC) #3
Leaf
Committed patchset #4 (id:60001) manually as cdbd586aed3630b676f351543bdff62374e93430 (presubmit successful).
4 years, 6 months ago (2016-06-02 02:21:50 UTC) #5
Jennifer Messerly
4 years, 6 months ago (2016-06-06 20:54:25 UTC) #7
Message was sent while issue was closed.
Great catch! That is how things should be set up to match how ES6 "extends"
works. LGTM

Powered by Google App Engine
This is Rietveld 408576698