New compilation API, part 2.

New compilation API, part 2.

This CL makes the Parser produce the data PreParser used to produce. This
enables us to get rid of the unnecessary preparsing phase.

The first part is here: https://codereview.chromium.org/199063003/

BUG=
R=dcarney@chromium.org, svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20075

[marja, 2014-03-18 14:26:16]

dcarney, ptal
(svenpanne, ptal at the api changes)

[dcarney, 2014-03-18 14:34:44]

lgtm

https://codereview.chromium.org/203353002/diff/80001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/203353002/diff/80001/include/v8.h#newcode1103
include/v8.h:1103: CachedData(const uint8_t* data, int length, bool owns_buffer
= false);
make enum

[marja, 2014-03-18 16:11:05]

thx

https://codereview.chromium.org/203353002/diff/80001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/203353002/diff/80001/include/v8.h#newcode1103
include/v8.h:1103: CachedData(const uint8_t* data, int length, bool owns_buffer
= false);
On 2014/03/18 14:34:44, dcarney wrote:
> make enum

Done.

[Sven Panne, 2014-03-19 12:04:52]

LGTM with a nit (I had a look at v8.h only)

https://codereview.chromium.org/203353002/diff/100001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/203353002/diff/100001/include/v8.h#newcode1107
include/v8.h:1107: // alive long enough.
I think the comment is out of date. Furthermore, we should note that if the data
is owned by CachedData, it will be deleted via 'delete[]'.

[marja, 2014-03-19 12:23:47]

thx for review!

https://codereview.chromium.org/203353002/diff/100001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/203353002/diff/100001/include/v8.h#newcode1107
include/v8.h:1107: // alive long enough.
On 2014/03/19 12:04:52, Sven Panne wrote:
> I think the comment is out of date. Furthermore, we should note that if the
data
> is owned by CachedData, it will be deleted via 'delete[]'.

Updated the comment to be:

If buffer_policy is BufferNotOwned, the caller keeps the ownership of data and
guarantees that it stays alive until the CachedData object is destroyed. If the
policy is BufferOwned, the given data will be deleted (with delete[]) when the
CachedData object is destroyed.

[marja, 2014-03-19 13:24:26]

Committed patchset #7 manually as r20075 (presubmit successful).