Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2033513003: (NOT FOR COMMIT) Testing layer invalidation speedups. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 428
429 // https://bugs.webkit.org/show_bug.cgi?id=61159 describes an unreproducible crash here, 429 // https://bugs.webkit.org/show_bug.cgi?id=61159 describes an unreproducible crash here,
430 // so assert but check that the layer is composited. 430 // so assert but check that the layer is composited.
431 ASSERT(compositingState() != NotComposited); 431 ASSERT(compositingState() != NotComposited);
432 432
433 // FIXME: generalize accessors to backing GraphicsLayers so that this code i s squashing-agnostic. 433 // FIXME: generalize accessors to backing GraphicsLayers so that this code i s squashing-agnostic.
434 if (layer()->groupedMapping()) { 434 if (layer()->groupedMapping()) {
435 LayoutRect paintInvalidationRect = r; 435 LayoutRect paintInvalidationRect = r;
436 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) { 436 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) {
437 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account. 437 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account.
438 squashingLayer->setNeedsDisplayInRect(enclosingIntRect(paintInvalida tionRect), invalidationReason, object); 438 (void)paintInvalidationRect;
439 (void)squashingLayer;
440 // TODO(vmiura): Add support for this mapping.
441 // squashingLayer->setNeedsDisplayInRect(enclosingIntRect(paintIn validationRect), invalidationReason, object);
439 } 442 }
440 } else { 443 } else {
441 layer()->compositedLayerMapping()->setContentsNeedDisplayInRect(r, inval idationReason, object); 444 layer()->compositedLayerMapping()->setContentsNeedDisplayInRect(r, inval idationReason, object);
442 } 445 }
443 } 446 }
444 447
445 void LayoutBoxModelObject::invalidateDisplayItemClientOnBacking(const DisplayIte mClient& displayItemClient, PaintInvalidationReason invalidationReason) const 448 void LayoutBoxModelObject::invalidateDisplayItemClientOnBacking(const DisplayIte mClient& displayItemClient, PaintInvalidationReason invalidationReason) const
446 { 449 {
447 if (layer()->groupedMapping()) { 450 if (layer()->groupedMapping()) {
448 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) 451 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer())
(...skipping 669 matching lines...) Expand 10 before | Expand all | Expand 10 after
1118 if (rootElementStyle->hasBackground()) 1121 if (rootElementStyle->hasBackground())
1119 return false; 1122 return false;
1120 1123
1121 if (node() != document().firstBodyElement()) 1124 if (node() != document().firstBodyElement())
1122 return false; 1125 return false;
1123 1126
1124 return true; 1127 return true;
1125 } 1128 }
1126 1129
1127 } // namespace blink 1130 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698