third_party/WebKit/Source/modules/webaudio/GainNode.cpp - Issue 2033503004: Avoid slow AudioParam automation path when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/GainNode.cpp

Issue 2033503004: Avoid slow AudioParam automation path when possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp ('k') | third_party/WebKit/Source/platform/audio/Biquad.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/GainNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/GainNode.cpp b/third_party/WebKit/Source/modules/webaudio/GainNode.cpp

index bada5970788b44c481b88a1e4286507de4adf35f..01b13808941f4918d0bb45477e5fb612e2b1ebdd 100644

--- a/third_party/WebKit/Source/modules/webaudio/GainNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/GainNode.cpp

@@ -67,6 +67,11 @@ void GainHandler::process(size_t framesToProcess)

float* gainValues = m_sampleAccurateGainValues.data();

m_gain->calculateSampleAccurateValues(gainValues, framesToProcess);

outputBus->copyWithSampleAccurateGainValuesFrom(*inputBus, gainValues, framesToProcess);

+ // Update m_lastGain so if the timeline ever ends, we get

+ // consistent data for the smoothing below. (Without this,

+ // m_lastGain was the last value before the timeline started

+ // procesing.

+ m_lastGain = gainValues[framesToProcess - 1];

}

} else {

// Apply the gain with de-zippering into the output bus.