Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2033503003: [Mac/iOS/GN] Add //build/toolchain/mac/filter_libtool.py. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/iOS/GN] Add //build/toolchain/mac/filter_libtool.py. This moves another step performed by gyp-mac-tool into a standalone script. BUG=616813 R=sdefresne@chromium.org Committed: https://crrev.com/88e841406ed2bcd559882c79ef254dac12f9c2a3 Cr-Commit-Position: refs/heads/master@{#397770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M build/toolchain/mac/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
A build/toolchain/mac/filter_libtool.py View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Robert Sesek
4 years, 6 months ago (2016-06-02 18:35:42 UTC) #1
sdefresne
lgtm
4 years, 6 months ago (2016-06-03 07:50:21 UTC) #2
Robert Sesek
+dpranke for OWNERS
4 years, 6 months ago (2016-06-03 14:05:54 UTC) #4
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-03 18:00:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033503003/1
4 years, 6 months ago (2016-06-03 18:02:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 19:09:10 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 19:10:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88e841406ed2bcd559882c79ef254dac12f9c2a3
Cr-Commit-Position: refs/heads/master@{#397770}

Powered by Google App Engine
This is Rietveld 408576698