Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2033483002: AIX: Define __STDC_FORMAT_MACROS in gypi file (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

AIX: Define __STDC_FORMAT_MACROS in gypi file Some system header files on AIX include inttypes.h without defining __STDC_FORMAT_MACROS and therefore the printf format specifier macro (for eg. PRId64) doesn't get defined as they are guarded with __STDC_FORMAT_MACROS macro on AIX. This error showed up recently when the format specifier was used in wasm-interpreter.cc, where a AIX system header file is included which also includes inttypes.h without defining __STDC_FORMAT_MACROS. R=ahaas@chromium.org, titzer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/b5a2b4db79ab187cacf229b5b2b3b446ac28bd84 Cr-Commit-Position: refs/heads/master@{#36682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gypfiles/toolchain.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-01 21:30:01 UTC) #1
titzer
lgtm
4 years, 6 months ago (2016-06-02 13:34:03 UTC) #2
JaideepBajwa
On 2016/06/02 13:34:03, titzer wrote: > lgtm thank you.
4 years, 6 months ago (2016-06-02 13:41:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033483002/1
4 years, 6 months ago (2016-06-02 13:42:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 14:02:48 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 14:04:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5a2b4db79ab187cacf229b5b2b3b446ac28bd84
Cr-Commit-Position: refs/heads/master@{#36682}

Powered by Google App Engine
This is Rietveld 408576698