Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2033443002: Fix doc on "Multiple outputs" for runtime_deps. (Closed)

Created:
4 years, 6 months ago by xhwang
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix doc on "Multiple outputs" for runtime_deps. Committed: https://crrev.com/0e85587e05893b1a8b53d8c80f38506dd3b06713 Cr-Commit-Position: refs/heads/master@{#397309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/gn/runtime_deps.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
xhwang
PTAL
4 years, 6 months ago (2016-06-01 20:21:54 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-01 21:30:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033443002/1
4 years, 6 months ago (2016-06-01 22:34:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239350)
4 years, 6 months ago (2016-06-02 02:10:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033443002/1
4 years, 6 months ago (2016-06-02 03:55:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239587)
4 years, 6 months ago (2016-06-02 04:29:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033443002/1
4 years, 6 months ago (2016-06-02 05:47:13 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 06:18:30 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 06:19:56 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e85587e05893b1a8b53d8c80f38506dd3b06713
Cr-Commit-Position: refs/heads/master@{#397309}

Powered by Google App Engine
This is Rietveld 408576698