Fixed type error in MapEntry and added keyToStringConfig to display the toString() of a key in a Ma…

Fixed type error in MapEntry and added keyToStringConfig to display the toString() of a key in a MapEntry preview.

BUG=
R=jacobr@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/1a3594910f58645398aee130d6621a0df34d97f3

[priscillalee, 2016-06-03 23:05:21]

priscillalee@google.com changed reviewers:
+ jacobr@google.com

[Jacob, 2016-06-03 23:11:50]

Looking good. A few minor comments.

https://codereview.chromium.org/2033433007/diff/1/tool/input_sdk/private/debu...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2033433007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:22: const keyToStringConfig =
"keyToStringConfig";
A cleaner solution would be to have an 
enum of configs
as only one config can be set at a time.
https://www.dartlang.org/docs/dart-up-and-running/ch02.html#enums

Add a enum entry that is 
Default to indicate no config is set.

https://codereview.chromium.org/2033433007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:93: NameValuePair({this.name, this.value,
bool skipDart, bool keyToString})
change this to just take an entry of the 
enum JsonMLConfig
instead of multiple bools.

https://codereview.chromium.org/2033433007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:203: if (identical(config, skipDartConfig)
|| isNativeJavaScriptObject(object)) {
switch to using == once you switch to an enum

https://codereview.chromium.org/2033433007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:210: if (identical(config,
keyToStringConfig)) {
switch to using == instead of identical

[priscillalee, 2016-06-07 22:58:02]

Now using a class JsonMLConfig instead of two Strings (tried to use an Enum, but
it failed).

https://codereview.chromium.org/2033433007/diff/1/tool/input_sdk/private/debu...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2033433007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:22: const keyToStringConfig =
"keyToStringConfig";
On 2016/06/03 23:11:50, Jacob wrote:
> A cleaner solution would be to have an 
> enum of configs
> as only one config can be set at a time.
> https://www.dartlang.org/docs/dart-up-and-running/ch02.html#enums
> 
> Add a enum entry that is 
> Default to indicate no config is set.

Used a class JsonMLConfig that simulated an enum instead.

https://codereview.chromium.org/2033433007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:93: NameValuePair({this.name, this.value,
bool skipDart, bool keyToString})
On 2016/06/03 23:11:50, Jacob wrote:
> change this to just take an entry of the 
> enum JsonMLConfig
> instead of multiple bools.

Done.

https://codereview.chromium.org/2033433007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:203: if (identical(config, skipDartConfig)
|| isNativeJavaScriptObject(object)) {
On 2016/06/03 23:11:50, Jacob wrote:
> switch to using == once you switch to an enum

Done.

https://codereview.chromium.org/2033433007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:210: if (identical(config,
keyToStringConfig)) {
On 2016/06/03 23:11:50, Jacob wrote:
> switch to using == instead of identical

Done.

[Jacob, 2016-06-07 23:17:41]

https://codereview.chromium.org/2033433007/diff/20001/tool/input_sdk/private/...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2033433007/diff/20001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:578: new NameValuePair(name: 'key', value:
object.key, config: JsonMLConfig.keyToString),
> 80 chars. run dartfmt and then you are good to submit.

[priscillalee, 2016-06-07 23:31:46]

Ran dartfmt to fix >80 char lines.

https://codereview.chromium.org/2033433007/diff/20001/tool/input_sdk/private/...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2033433007/diff/20001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:578: new NameValuePair(name: 'key', value:
object.key, config: JsonMLConfig.keyToString),
On 2016/06/07 23:17:41, Jacob wrote:
> > 80 chars. run dartfmt and then you are good to submit.

Done.

[Jacob, 2016-06-08 17:08:53]

lgtm

[priscillalee, 2016-06-08 17:13:01]

Description was changed from

==========
Fixed type error in MapEntry and added keyToStringConfig to display the
toString() of a key in a MapEntry preview.

BUG=
==========

to

==========
Fixed type error in MapEntry and added keyToStringConfig to display the
toString() of a key in a MapEntry preview.

BUG=
R=jacobr@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/1a3594910f58645398aee130d662...
==========

[priscillalee, 2016-06-08 17:13:02]

Committed patchset #3 (id:40001) manually as
1a3594910f58645398aee130d6621a0df34d97f3 (presubmit successful).