Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: ui/views/controls/menu/menu_controller.h

Issue 2033433006: MacViews: Modify insertText handlers to correctly handle space key and simplify menu event dispatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failing interactive_ui_tests. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/button/custom_button_unittest.cc ('k') | ui/views/controls/menu/menu_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_controller.h
diff --git a/ui/views/controls/menu/menu_controller.h b/ui/views/controls/menu/menu_controller.h
index bf97e15ebbeeb3ad37a244ffd078e929af8ff1e2..e5ca2cc5db0499c140eb60aa0f2229b33845c241 100644
--- a/ui/views/controls/menu/menu_controller.h
+++ b/ui/views/controls/menu/menu_controller.h
@@ -177,11 +177,8 @@ class VIEWS_EXPORT MenuController : public WidgetObserver {
void OnDragComplete(bool should_close);
// Called while dispatching messages to intercept key events.
- // If |character| is other than 0, it is handled as a mnemonic.
- // Otherwise, |key_code| is handled as a menu navigation command.
// Returns ui::POST_DISPATCH_NONE if the event was swallowed by the menu.
- ui::PostDispatchAction OnWillDispatchKeyEvent(base::char16 character,
- ui::KeyboardCode key_code);
+ ui::PostDispatchAction OnWillDispatchKeyEvent(ui::KeyEvent* event);
// Update the submenu's selection based on the current mouse location
void UpdateSubmenuSelection(SubmenuView* source);
« no previous file with comments | « ui/views/controls/button/custom_button_unittest.cc ('k') | ui/views/controls/menu/menu_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698