MacViews: Modify insertText handlers to correctly handle space key and simplify menu event dispatch.

ui/views/controls/menu/menu_controller.cc

Index: ui/views/controls/menu/menu_controller.cc
diff --git a/ui/views/controls/menu/menu_controller.cc b/ui/views/controls/menu/menu_controller.cc
index 030600f84cc8b37673ff65c744c67c5c68e11f35..02a5b62841fec89da5920a4ec418d95abb751d8b 100644
--- a/ui/views/controls/menu/menu_controller.cc
+++ b/ui/views/controls/menu/menu_controller.cc
@@ -1023,18 +1023,17 @@ void MenuController::OnDragComplete(bool should_close) {
 }
 
 ui::PostDispatchAction MenuController::OnWillDispatchKeyEvent(
-    base::char16 character,
-    ui::KeyboardCode key_code) {
+    const ui::KeyEvent& key_event) {

[tapted, 2016/06/06 04:44:05]

Is there a way of having MenuKeyEventHandler::OnKeyEvent call this? I think it
would be good to merge the logic for these in case some fixes are missing or get
lost in future

[karandeepb, 2016/06/06 11:21:10]

Done. 

   if (exit_type() == MenuController::EXIT_ALL ||
       exit_type() == MenuController::EXIT_DESTROYED) {
     TerminateNestedMessageLoopIfNecessary();
     return ui::POST_DISPATCH_PERFORM_DEFAULT;
   }
 
-  if (character)
-    SelectByChar(character);
+  if (key_event.is_char())
+    SelectByChar(key_event.GetCharacter());
   else
-    OnKeyDown(key_code);
+    OnKeyDown(key_event.key_code());
 
   // MenuController may have been deleted, so check for an active instance
   // before accessing member variables.