MacViews: Modify insertText handlers to correctly handle space key and simplify menu event dispatch.

ui/base/test/ui_controls_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/test/ui_controls.h"
 
 #import <Cocoa/Cocoa.h>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/message_loop/message_loop.h"
 #include "ui/base/cocoa/cocoa_base_utils.h"
 #include "ui/events/keycodes/keyboard_code_conversion_mac.h"
 #import "ui/events/test/cocoa_test_event_utils.h"
 
-// Implementation details: We use [NSApplication sendEvent:] instead
-// of [NSApplication postEvent:atStart:] so that the event gets sent
-// immediately.  This lets us run the post-event task right

[tapted, 2016/06/06 04:44:05]

So, sadly we will need to land the change that converts this from sendEvent to
postEvent separately -- there may be some subtle changes (e.g. maybe things
become flaky on some bots), and some other Cocoa folks should look at it too.

[karandeepb, 2016/06/06 11:21:09]

Done. See crrev.com/2035393002.

-// immediately as well.  Unfortunately I cannot subclass NSEvent (it's
-// probably a class cluster) to allow other easy answers.  For
-// example, if I could subclass NSEvent, I could run the Task in it's
-// dealloc routine (which necessarily happens after the event is
-// dispatched).  Unlike Linux, Mac does not have message loop
-// observer/notification.  Unlike windows, I cannot post non-events

[tapted, 2016/06/06 04:44:05]

Should we keep some of these notes?

[karandeepb, 2016/06/06 11:21:09]

These notes are explaining why [NSApp sendEvent] is being used. But since we are
removing the last usage of sendEvent from this file, these should probably be
removed.

-// into the event queue.  (I can post other kinds of tasks but can't
-// guarantee their order with regards to events).
-
-// But [NSApplication sendEvent:] causes a problem when sending mouse click
+// [NSApplication sendEvent:] causes a problem when sending mouse click
 // events. Because in order to handle mouse drag, when processing a mouse
 // click event, the application may want to retrieve the next event
 // synchronously by calling NSApplication's nextEventMatchingMask method.
 // In this case, [NSApplication sendEvent:] causes deadlock.
-// So we need to use [NSApplication postEvent:atStart:] for mouse click
-// events. In order to notify the caller correctly after all events has been
+// Also since events sent using [NSApp sendEvent] are not added to the event
+// queue but instead are invoked directly from the main event loop,
+// [NSApp currentEvent] does not report the correct event for it.
+// So we need to use [NSApplication postEvent:atStart:].
+// In order to notify the caller correctly after all events has been

[tapted, 2016/06/06 04:44:05]

has -> have

[karandeepb, 2016/06/06 11:21:09]

Done.

 // processed, we setup a task to watch for the event queue time to time and
 // notify the caller as soon as there is no event in the queue.
 //
 // TODO(suzhe):
 // 1. Investigate why using [NSApplication postEvent:atStart:] for keyboard
 //    events causes BrowserKeyEventsTest.CommandKeyEvents to fail.
 //    See http://crbug.com/49270
 // 2. On OSX 10.6, [NSEvent addLocalMonitorForEventsMatchingMask:handler:] may
 //    be used, so that we don't need to poll the event queue time to time.
 
@@ skipping 158 matching lines @@
                                 bool alt,
                                 bool command,
                                 const base::Closure& task) {
   CHECK(g_ui_controls_enabled);
   DCHECK(base::MessageLoopForUI::IsCurrent());
 
   std::vector<NSEvent*> events;
   SynthesizeKeyEventsSequence(
       window, key, control, shift, alt, command, &events);
 
-  // TODO(suzhe): Using [NSApplication postEvent:atStart:] here causes
-  // BrowserKeyEventsTest.CommandKeyEvents to fail. See http://crbug.com/49270
-  // But using [NSApplication sendEvent:] should be safe for keyboard events,
-  // because until now, no code wants to retrieve the next event when handling
-  // a keyboard event.
   for (std::vector<NSEvent*>::iterator iter = events.begin();
        iter != events.end(); ++iter)
-    [[NSApplication sharedApplication] sendEvent:*iter];
+    [[NSApplication sharedApplication] postEvent:*iter atStart:NO];
 
   if (!task.is_null()) {
     base::MessageLoop::current()->PostTask(
         FROM_HERE, base::Bind(&EventQueueWatcher, task));
   }
 
   return true;
 }
 
 bool SendMouseMove(long x, long y) {
@@ skipping 107 matching lines @@
 void RunClosureAfterAllPendingUIEvents(const base::Closure& closure) {
   base::MessageLoop::current()->PostTask(
       FROM_HERE, base::Bind(&EventQueueWatcher, closure));
 }
 
 bool IsFullKeyboardAccessEnabled() {
   return [NSApp isFullKeyboardAccessEnabled];
 }
 
 }  // namespace ui_controls