Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui/InplaceEditor.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 */ 7 */
8 WebInspector.InplaceEditor = function() 8 WebInspector.InplaceEditor = function()
9 { 9 {
10 } 10 }
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 * @param {!Event} event 173 * @param {!Event} event
174 * @return {string} 174 * @return {string}
175 */ 175 */
176 function defaultFinishHandler(event) 176 function defaultFinishHandler(event)
177 { 177 {
178 var isMetaOrCtrl = WebInspector.isMac() ? 178 var isMetaOrCtrl = WebInspector.isMac() ?
179 event.metaKey && !event.shiftKey && !event.ctrlKey && !event.alt Key : 179 event.metaKey && !event.shiftKey && !event.ctrlKey && !event.alt Key :
180 event.ctrlKey && !event.shiftKey && !event.metaKey && !event.alt Key; 180 event.ctrlKey && !event.shiftKey && !event.metaKey && !event.alt Key;
181 if (isEnterKey(event) && (event.isMetaOrCtrlForTest || !isMultiline || isMetaOrCtrl)) 181 if (isEnterKey(event) && (event.isMetaOrCtrlForTest || !isMultiline || isMetaOrCtrl))
182 return "commit"; 182 return "commit";
183 else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Esc.co de || event.keyIdentifier === "U+001B") 183 else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Esc.co de || event.key === "Escape")
184 return "cancel"; 184 return "cancel";
185 else if (!isMultiline && event.keyIdentifier === "U+0009") // Tab ke y 185 else if (!isMultiline && event.key === "Tab")
186 return "move-" + (event.shiftKey ? "backward" : "forward"); 186 return "move-" + (event.shiftKey ? "backward" : "forward");
187 return ""; 187 return "";
188 } 188 }
189 189
190 function handleEditingResult(result, event) 190 function handleEditingResult(result, event)
191 { 191 {
192 if (result === "commit") { 192 if (result === "commit") {
193 editingCommitted.call(element); 193 editingCommitted.call(element);
194 event.consume(true); 194 event.consume(true);
195 } else if (result === "cancel") { 195 } else if (result === "cancel") {
196 editingCancelled.call(element); 196 editingCancelled.call(element);
197 event.consume(true); 197 event.consume(true);
198 } else if (result && result.startsWith("move-")) { 198 } else if (result && result.startsWith("move-")) {
199 moveDirection = result.substring(5); 199 moveDirection = result.substring(5);
200 if (event.keyIdentifier !== "U+0009") 200 if (event.key !== "Tab")
201 blurEventListener(); 201 blurEventListener();
202 } 202 }
203 } 203 }
204 204
205 /** 205 /**
206 * @param {!Event} event 206 * @param {!Event} event
207 */ 207 */
208 function pasteEventListener(event) 208 function pasteEventListener(event)
209 { 209 {
210 var result = pasteCallback(event); 210 var result = pasteCallback(event);
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 }, 292 },
293 293
294 /** 294 /**
295 * @param {function(!Event):string} postKeydownFinishHandler 295 * @param {function(!Event):string} postKeydownFinishHandler
296 */ 296 */
297 setPostKeydownFinishHandler: function(postKeydownFinishHandler) 297 setPostKeydownFinishHandler: function(postKeydownFinishHandler)
298 { 298 {
299 this.postKeydownFinishHandler = postKeydownFinishHandler; 299 this.postKeydownFinishHandler = postKeydownFinishHandler;
300 } 300 }
301 } 301 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698