Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 2033403005: Eradicate keyIndentifier from devtools/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call KeyCodeToKeyIdentifier for unhandle key events Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 } else { 418 } else {
419 this._statusMessageElement.removeChildren(); 419 this._statusMessageElement.removeChildren();
420 this._statusMessageElement.appendChild(status); 420 this._statusMessageElement.appendChild(status);
421 } 421 }
422 }, 422 },
423 423
424 _keyDown: function(event) 424 _keyDown: function(event)
425 { 425 {
426 if (event.altKey || event.shiftKey || event.metaKey || event.ctrlKey) 426 if (event.altKey || event.shiftKey || event.metaKey || event.ctrlKey)
427 return; 427 return;
428 if (event.keyIdentifier === "Up" && this._selectPreviousCallFrameOnStack () || event.keyIdentifier === "Down" && this._selectNextCallFrameOnStack()) 428 if (event.key === "ArrowUp" && this._selectPreviousCallFrameOnStack() || event.key === "ArrowDown" && this._selectNextCallFrameOnStack())
429 event.consume(true); 429 event.consume(true);
430 }, 430 },
431 431
432 __proto__: WebInspector.SidebarPane.prototype 432 __proto__: WebInspector.SidebarPane.prototype
433 } 433 }
434 434
435 /** 435 /**
436 * @constructor 436 * @constructor
437 * @extends {WebInspector.UIList.Item} 437 * @extends {WebInspector.UIList.Item}
438 * @param {string} functionName 438 * @param {string} functionName
(...skipping 28 matching lines...) Expand all
467 var uiLocation = liveLocation.uiLocation(); 467 var uiLocation = liveLocation.uiLocation();
468 if (!uiLocation) 468 if (!uiLocation)
469 return; 469 return;
470 var text = uiLocation.linkText(); 470 var text = uiLocation.linkText();
471 this.setSubtitle(text.trimMiddle(30)); 471 this.setSubtitle(text.trimMiddle(30));
472 this.subtitleElement.title = text; 472 this.subtitleElement.title = text;
473 }, 473 },
474 474
475 __proto__: WebInspector.UIList.Item.prototype 475 __proto__: WebInspector.UIList.Item.prototype
476 } 476 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698